Re: linux-next: driver-core tree build warning

[Greg KH <greg@kroah.com>]

On Thu, Apr 30, 2009 at 10:47:27PM -0700, Greg KH wrote:
> On Fri, May 01, 2009 at 03:21:44PM +1000, Stephen Rothwell wrote:
> > Hi Greg,
> > 
> > Today's linux-next build (x86_64 allmodconfig) produced these warnings:
> > 
> > drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_cfg':
> > drivers/net/wireless/ipw2x00/ipw2100.c:3491: warning: passing argument 1 of 'dev_get_drvdata' from incompatible pointer type
> > include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct device **'
> > drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_status':
> > drivers/net/wireless/ipw2x00/ipw2100.c:3500: warning: passing argument 1 of 'dev_get_drvdata' from incompatible pointer type
> > include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct device **'
> > drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_capability':
> > drivers/net/wireless/ipw2x00/ipw2100.c:3509: warning: passing argument 1 of 'dev_get_drvdata' from incompatible pointer type
> > include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct device **'
> > drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_rf_kill':
> > drivers/net/wireless/ipw2x00/ipw2100.c:4227: warning: passing argument 1 of 'dev_get_drvdata' from incompatible pointer type
> > include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct device **'
> > 
> > Introduced by commit 73119f5e60e3b16577e99e2f035039bed0d2dcca ("Wireless:
> > remove driver_data direct access of struct device").
> 
> Ah crap, my bad.  I'll go fix this up, it passed my build tests, I
> wonder why this isn't an error, I missed the warning.

I've sent an updated version of the patch that fixes this to John and
the wireless mailing list and updated my tree as well.

thanks,

greg k-h