All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Bob Copeland <me@bobcopeland.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] appletouch: fix DMA to/from stack buffer
Date: Fri, 1 May 2009 06:36:36 -0700	[thread overview]
Message-ID: <200905010636.36778.dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <1240908294.19534.2.camel@johannes.local>

On Tue, Apr 28, 2009 at 10:44:54AM +0200, Johannes Berg wrote:
> On Mon, 2009-04-27 at 21:58 -0400, Bob Copeland wrote:
> > CONFIG_DMA_API_DEBUG spotted an instance of appletouch using
> > an array on the stack as a DMA buffer for certain hardware.
> > Change it to use a kmalloc()ed buffer instead.
> > 
> > This fixes the following error:
> 
> > Signed-off-by: Bob Copeland <me@bobcopeland.com>
> 
> Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
> 
> Interestingly, I first thought the GFP_KERNEL is wrong due to
> atp_reinit, but the GFP_ATOMIC in that is wrong instead :)
> 

Applied to 'for-linus' branch, thank you.

-- 
Dmitry


      reply	other threads:[~2009-05-01 13:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-28  1:58 [PATCH] appletouch: fix DMA to/from stack buffer Bob Copeland
2009-04-28  8:44 ` Johannes Berg
2009-05-01 13:36   ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905010636.36778.dmitry.torokhov@gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@bobcopeland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.