From: Theodore Tso <tytso@mit.edu>
To: Andreas Dilger <adilger@sun.com>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 3/3] ext4: Use separate super_operations structure for no_journal filesystems
Date: Fri, 1 May 2009 09:49:12 -0400 [thread overview]
Message-ID: <20090501134912.GD7681@mit.edu> (raw)
In-Reply-To: <20090501104253.GC3209@webber.adilger.int>
On Fri, May 01, 2009 at 04:42:53AM -0600, Andreas Dilger wrote:
> On May 01, 2009 00:37 -0400, Theodore Ts'o wrote:
> > @@ -3923,6 +3911,12 @@ static int __init init_ext4_fs(void)
> > + ext4_nojournal_sops = ext4_sops;
> > + ext4_nojournal_sops.write_super = ext4_write_super;
> > + ext4_nojournal_sops.sync_fs = 0;
> > + ext4_nojournal_sops.freeze_fs = 0;
> > + ext4_nojournal_sops.unfreeze_fs = 0;
>
> I thought the general policy these days was to make a static const
> ops struct so that it cannot be changed (correctly or incorrectly)?
The tradeoff is this makes it much easier from a maintenance point of
view to see what the differences are between ext4_nojournal_sops and
ext4_journal_sops.
- Ted
next prev parent reply other threads:[~2009-05-01 13:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-01 4:37 [PATCH 1/3] ext4: Simplify ext4_commit_super()'s function signature Theodore Ts'o
2009-05-01 4:37 ` [PATCH 2/3] ext4: Fix and simplify s_dirt handling Theodore Ts'o
2009-05-01 4:37 ` [PATCH 3/3] ext4: Use separate super_operations structure for no_journal filesystems Theodore Ts'o
2009-05-01 7:04 ` Christoph Hellwig
2009-05-01 13:48 ` Theodore Tso
2009-05-01 14:24 ` Christoph Hellwig
2009-05-01 10:42 ` Andreas Dilger
2009-05-01 13:49 ` Theodore Tso [this message]
2009-05-01 14:47 ` Christoph Hellwig
2009-05-01 16:55 ` [PATCH v2] " Theodore Ts'o
2009-05-01 7:02 ` [PATCH 2/3] ext4: Fix and simplify s_dirt handling Christoph Hellwig
2009-05-01 13:45 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090501134912.GD7681@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@sun.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.