From: Alasdair G Kergon <agk@redhat.com>
To: device-mapper development <dm-devel@redhat.com>
Subject: Re: Re: [PATCH] raid1: use __GFP_NOFAIL
Date: Fri, 1 May 2009 19:15:59 +0100 [thread overview]
Message-ID: <20090501181559.GF23302@agk.fab.redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0905010801490.16859@hs20-bc2-1.build.redhat.com>
On Fri, May 01, 2009 at 08:04:12AM -0400, Mikulas Patocka wrote:
> As I said on chat, don't remove that GFP_IO allocation. The code is
> deadlocky anyway and allocation from a mempool with GFP_ATOMIC and, in
> case of failure, allocation from memory with GFP_IO is the best that can
> be done to reduce the probability of the deadlock.
OK - I'll apply this one pending a more-complicated fix that uses the
mempool correctly.
Alasdair
--
agk@redhat.com
prev parent reply other threads:[~2009-05-01 18:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-27 11:01 [PATCH] raid1: use __GFP_NOFAIL Mikulas Patocka
2009-04-30 23:14 ` Alasdair G Kergon
2009-05-01 12:04 ` Mikulas Patocka
2009-05-01 18:15 ` Alasdair G Kergon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090501181559.GF23302@agk.fab.redhat.com \
--to=agk@redhat.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.