From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1M0DZB-0002lJ-OG for mharc-grub-devel@gnu.org; Sat, 02 May 2009 07:39:37 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M0DZA-0002kQ-VT for grub-devel@gnu.org; Sat, 02 May 2009 07:39:37 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M0DZ6-0002e0-DA for grub-devel@gnu.org; Sat, 02 May 2009 07:39:36 -0400 Received: from [199.232.76.173] (port=52496 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M0DZ6-0002di-2y for grub-devel@gnu.org; Sat, 02 May 2009 07:39:32 -0400 Received: from aybabtu.com ([69.60.117.155]:58889) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M0DZ5-0007zU-MA for grub-devel@gnu.org; Sat, 02 May 2009 07:39:31 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1M0DLp-0001bU-Py for grub-devel@gnu.org; Sat, 02 May 2009 13:25:50 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1M0DZ2-0007PF-N6 for grub-devel@gnu.org; Sat, 02 May 2009 13:39:28 +0200 Date: Sat, 2 May 2009 13:39:28 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090502113928.GC28362@thorin> References: <1240890910.29799.104.camel@mj> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1240890910.29799.104.camel@mj> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Crash in usb_keyboard X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 May 2009 11:39:37 -0000 On Mon, Apr 27, 2009 at 11:55:10PM -0400, Pavel Roskin wrote: > Hello! > > Running "terminal_input.usb_keyboard" crashed GRUB (or qemu it's running > in). It turns out we never check if usbdev in term/usb_keyboard.c is > not NULL. It is NULL if no USB host controllers have been detected. > > I'm not sure if we even want to call grub_term_register_input() if no > USB keyboard is present. What if a keyboard is not present, but plugged in later? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."