All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4] Marvell Kirkwood family SOC support
Date: Sat, 2 May 2009 13:40:18 +0200	[thread overview]
Message-ID: <20090502114018.GD25959@game.jcrosoft.org> (raw)
In-Reply-To: <1241024255-14548-1-git-send-email-prafulla@marvell.com>

> +
> +	if ((!enable) || (bank > BANK3))
> +		return 0;
> +	result = 0xff000000 & readl(KW_REG_CPUCS_WIN_SZ(bank));
> +	result += 0x01000000;
> +	return result;
> +}
> diff --git a/cpu/arm926ejs/kirkwood/kwcore.c b/cpu/arm926ejs/kirkwood/kwcore.c
> new file mode 100644
> index 0000000..9eaaab6
> --- /dev/null
> +++ b/cpu/arm926ejs/kirkwood/kwcore.c
please cpu.c
> @@ -0,0 +1,284 @@
> +/*
> + * (C) Copyright 2009
> + * Marvell Semiconductor <www.marvell.com>
> + * Prafulla Wadaskar <prafulla@marvell.com>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
> + * MA 02110-1301 USA
> + */

> diff --git a/cpu/arm926ejs/start.S b/cpu/arm926ejs/start.S
> index ed4932a..bdbb7e0 100644
> --- a/cpu/arm926ejs/start.S
> +++ b/cpu/arm926ejs/start.S
> @@ -139,7 +139,7 @@ reset:
>  	 * we do sys-critical inits only at reboot,
>  	 * not when booting from ram!
>  	 */
> -#ifndef CONFIG_SKIP_LOWLEVEL_INIT
> +#if !defined (CONFIG_SKIP_LOWLEVEL_INIT) || defined (CONFIG_ARCH_LOWLEVEL_INIT)
>  	bl	cpu_init_crit
>  #endif
>  
> @@ -201,7 +201,7 @@ _start_armboot:
>   *
>   *************************************************************************
>   */
> -#ifndef CONFIG_SKIP_LOWLEVEL_INIT
> +#if !defined (CONFIG_SKIP_LOWLEVEL_INIT) || defined (CONFIG_ARCH_LOWLEVEL_INIT)
NACK

if you skip the lowlevel init you also skip the arch lowlevel_init

if it's permannent arch init please use arch_cpu_init

Best regards,
J.

  reply	other threads:[~2009-05-02 11:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-29 16:57 [U-Boot] [PATCH v4] Marvell Kirkwood family SOC support Prafulla Wadaskar
2009-05-02 11:40 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-05-02 21:41   ` Prafulla Wadaskar
2009-05-03  8:32     ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-03 17:16       ` Prafulla Wadaskar
2009-05-03 20:48         ` Wolfgang Denk
2009-05-03 21:52         ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090502114018.GD25959@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.