From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1M0Dbb-0005Ta-30 for mharc-grub-devel@gnu.org; Sat, 02 May 2009 07:42:07 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M0DbY-0005Qv-GE for grub-devel@gnu.org; Sat, 02 May 2009 07:42:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M0DbT-0005Ka-2L for grub-devel@gnu.org; Sat, 02 May 2009 07:42:03 -0400 Received: from [199.232.76.173] (port=60073 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M0DbS-0005KQ-Nv for grub-devel@gnu.org; Sat, 02 May 2009 07:41:58 -0400 Received: from aybabtu.com ([69.60.117.155]:58772) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M0DbR-0008NE-UA for grub-devel@gnu.org; Sat, 02 May 2009 07:41:58 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1M0DOB-0001bl-OO for grub-devel@gnu.org; Sat, 02 May 2009 13:28:16 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1M0DbP-0007PX-14 for grub-devel@gnu.org; Sat, 02 May 2009 13:41:55 +0200 Date: Sat, 2 May 2009 13:41:55 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090502114155.GE28362@thorin> References: <1239833453.8204.18.camel@mj> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1239833453.8204.18.camel@mj> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Code quality X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 May 2009 11:42:04 -0000 On Wed, Apr 15, 2009 at 06:10:53PM -0400, Pavel Roskin wrote: > Hello! > > It seems to me that the code quality has decreased in the last weeks. > In the same time, we have a growing number of compiler warnings. It > looks like there is a relationship between the two. > > I'll appreciate if everybody who recently contributed to GRUB looks at > the remaining warnings and fixes at least some of them. I don't mean > hiding the warnings, e.g. adding casts where using different types would > be more appropriate or initializing variables gcc claims to be > uninitialized without making sure that gcc is indeed wrong. But if > there is a good fix, it should be applied. Can we start using -Werror ? If we can't do it globally, at least for individual modules. This way we gradually prevent regressions in more areas, and (hopefully) at some point get rid of them. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."