All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: Karel Zak <kzak@redhat.com>
Cc: linux-ext4@vger.kernel.org, Eric Sandeen <sandeen@redhat.com>
Subject: Re: [PATCH] blkid: use /dev/mapper/<name> rather than /dev/dm-<N>
Date: Sat, 2 May 2009 22:05:28 -0400	[thread overview]
Message-ID: <20090503020528.GA25826@mit.edu> (raw)
In-Reply-To: <1240837258-5440-1-git-send-email-kzak@redhat.com>

On Mon, Apr 27, 2009 at 03:00:57PM +0200, Karel Zak wrote:
> The libblkid (since v1.41.1) returns private device-mapper names (e.g.
> /dev/dm-0). It's because the probe_one() function scans /dev before
> /dev/mapper.

Checked in, thanks.  Debian-derived distributions don't create
/dev/dm-X names, which is why I didn't notice this issue.  However,
because of this, I modified your patch to keep this chunk which you removed:

> -	/* Do a short-cut scan of /dev/mapper first */
> -	if (!devname)
> -		blkid__scan_dir("/dev/mapper", devno, 0, &devname);

For distributions that don't create /dev/dm-X devices, your check
above won't find the device name, so after searching /dev, we need to
do a short-cut scan of /dev/mapper before we do a full brute force
search via blkid_devno_to_devname.

							- Ted

  parent reply	other threads:[~2009-05-03  2:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-27 13:00 [PATCH] blkid: use /dev/mapper/<name> rather than /dev/dm-<N> Karel Zak
2009-04-27 13:00 ` [PATCH] blkid: use /sys/block/dm-<N>/dm/name Karel Zak
2009-05-03  2:41   ` Theodore Tso
2009-05-03  2:05 ` Theodore Tso [this message]
2009-05-05 19:54   ` [PATCH] blkid: use /dev/mapper/<name> rather than /dev/dm-<N> Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090503020528.GA25826@mit.edu \
    --to=tytso@mit.edu \
    --cc=kzak@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.