From: "Mario 'BitKoenig' Holbe" <Mario.Holbe@TU-Ilmenau.DE>
To: NeilBrown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org
Subject: Re: Incorrect in-kernel bitmap on raid10
Date: Sun, 3 May 2009 15:22:30 +0200 [thread overview]
Message-ID: <20090503132230.GA23302@darkside.22.kls.lan> (raw)
In-Reply-To: <a960aae116852f769f6e223581fa6835.squirrel@neil.brown.name>
[-- Attachment #1: Type: text/plain, Size: 1368 bytes --]
On Sun, May 03, 2009 at 08:41:49AM +1000, NeilBrown wrote:
> I managed to reproduce this thanks to all the detail you provided.
> The problem was caused by trying to add a device to the array while the
> array was readonly.
Okay, I understand. I was just trying to find a way to sync all the
spares simultaneously.
> Can you duplicated the problem without setting the array to readonly?
No, mdadm -A /dev/md7; mdadm --add /dev/md7 /dev/sd[fgh]1 seems to
respect the bitmap, but first adds the first spare only and the two
remaining spares when the first resync has been finished.
According to your previous mail, I will run into your case 3/ this way,
the bug where the bitmap is cleared too early, will I?
I'm very willing to test your announced patch :)
> Yes, it would be nice to be able to add multiple devices at once.
> Maybe I could just get the kernel to wait 100ms after an add before
This is probably the easiest way to work around this issue on the short
run. However, such kind of timeouts cry for race conditions. Perhaps,
allowing to add spares in read-only mode or some flag like "wait for
confirmation before starting to resync" would be a cleaner approach on
the long run.
Thank you very much for your help
Mario
--
Gemuese schmeckt am besten, wenn man es kurz vor dem Verzehr durch ein
Schnitzel ersetzt!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 481 bytes --]
next prev parent reply other threads:[~2009-05-03 13:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-18 18:15 Incorrect in-kernel bitmap on raid10 Mario 'BitKoenig' Holbe
2009-04-19 6:24 ` Neil Brown
2009-04-19 22:55 ` Mario 'BitKoenig' Holbe
2009-04-19 23:27 ` Neil Brown
2009-04-20 0:13 ` Race condition in write_sb_page? (was: Re: Incorrect in-kernel bitmap on raid10) Mario 'BitKoenig' Holbe
2009-04-20 1:57 ` NeilBrown
2009-04-20 8:03 ` Race condition in write_sb_page? Mario 'BitKoenig' Holbe
2009-04-22 18:45 ` Incorrect in-kernel bitmap on raid10 Mario 'BitKoenig' Holbe
2009-04-28 14:05 ` Mario 'BitKoenig' Holbe
2009-05-01 2:11 ` Neil Brown
2009-05-01 17:55 ` Mario 'BitKoenig' Holbe
2009-05-01 21:36 ` NeilBrown
2009-05-02 19:52 ` Mario 'BitKoenig' Holbe
2009-05-02 22:41 ` NeilBrown
2009-05-03 13:22 ` Mario 'BitKoenig' Holbe [this message]
2009-05-07 20:25 ` Mario 'BitKoenig' Holbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090503132230.GA23302@darkside.22.kls.lan \
--to=mario.holbe@tu-ilmenau.de \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.