From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1M0ihs-0000U1-7J for mharc-grub-devel@gnu.org; Sun, 03 May 2009 16:54:40 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M0ihq-0000Sd-Ps for grub-devel@gnu.org; Sun, 03 May 2009 16:54:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M0ihl-0000Lt-MO for grub-devel@gnu.org; Sun, 03 May 2009 16:54:37 -0400 Received: from [199.232.76.173] (port=41598 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M0ihl-0000Lh-IV for grub-devel@gnu.org; Sun, 03 May 2009 16:54:33 -0400 Received: from aybabtu.com ([69.60.117.155]:40790) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M0ihl-0000em-4V for grub-devel@gnu.org; Sun, 03 May 2009 16:54:33 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1M0iUM-0004Cw-Rv for grub-devel@gnu.org; Sun, 03 May 2009 22:40:43 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1M0ihh-0002Hu-UJ for grub-devel@gnu.org; Sun, 03 May 2009 22:54:29 +0200 Date: Sun, 3 May 2009 22:54:29 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090503205429.GA8753@thorin> References: <20090502111547.GA28211@thorin> <1241325308.8745.39.camel@ct> <20090503165547.GC22078@thorin> <1241370273.4472.30.camel@ct> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1241370273.4472.30.camel@ct> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] improve error messages in grub-setup X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 May 2009 20:54:39 -0000 On Sun, May 03, 2009 at 01:04:33PM -0400, Pavel Roskin wrote: > On Sun, 2009-05-03 at 18:55 +0200, Robert Millan wrote: > > > Agreed. It's no harm to add --force for users who are stuck in such layouts. > > > > Here's a new patch. > > I don't see the "force" variable affecting anything in setup() other > than output. There is, see: + grub_util_warn ("Embedding is not possible. GRUB can only be installed in this " + "setup by using blocklists. However, blocklists are UNRELIABLE and " + "its use is discouraged."); + if (! force) + grub_util_error ("If you really want blocklists, use --force."); The first is always displayed, the latter only when we don't have --force > grub_util_warn() doesn't set any flag that there have been > warnings. That's an option, too. But it would preclude the possibility of issuing warnings for which we don't want to require --force (i.e. lesser evils). I wonder if that would be a problem? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."