All of lore.kernel.org
 help / color / mirror / Atom feed
From: Valerie Aurora <vaurora@redhat.com>
To: Nick Dokos <nicholas.dokos@hp.com>
Cc: linux-ext4@vger.kernel.org, "Theodore Ts'o" <tytso@mit.edu>
Subject: Re: [PATCH 2/6] [64-bit] write_bitmaps(): blk_t -> blk64_t
Date: Mon, 4 May 2009 02:20:33 -0400	[thread overview]
Message-ID: <20090504062033.GD9151@shell> (raw)
In-Reply-To: <15560.1241167591@gamaville.dokosmarshall.org>

On Fri, May 01, 2009 at 04:46:31AM -0400, Nick Dokos wrote:
> write_bitmaps() was truncating blocks numbers to 32 bits and therefore
> writing at the wrong place on the disk.
> 
> Signed-off-by: Nick Dokos <nicholas.dokos@hp.com>
> ---
>  lib/ext2fs/rw_bitmaps.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/ext2fs/rw_bitmaps.c b/lib/ext2fs/rw_bitmaps.c
> index 5b504bf..da472a8 100644
> --- a/lib/ext2fs/rw_bitmaps.c
> +++ b/lib/ext2fs/rw_bitmaps.c
> @@ -36,8 +36,8 @@ static errcode_t write_bitmaps(ext2_filsys fs, int do_inode, int do_block)
>  	errcode_t	retval;
>  	char 		*block_buf, *inode_buf;
>  	int		csum_flag = 0;
> -	blk_t		blk;
> -	blk_t		blk_itr = fs->super->s_first_data_block;
> +	blk64_t		blk;
> +	blk64_t		blk_itr = fs->super->s_first_data_block;
>  	ext2_ino_t	ino_itr = 1;
>  
>  	EXT2_CHECK_MAGIC(fs, EXT2_ET_MAGIC_EXT2FS_FILSYS);
> -- 
> 1.6.0.6
> 

Signed-off-by: Valerie Aurora (Henson) <vaurora@redhat.com>

-VAL

      reply	other threads:[~2009-05-04  6:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-01  8:46 [PATCH 2/6] [64-bit] write_bitmaps(): blk_t -> blk64_t Nick Dokos
2009-05-04  6:20 ` Valerie Aurora [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090504062033.GD9151@shell \
    --to=vaurora@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=nicholas.dokos@hp.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.