From: Valerie Aurora <vaurora@redhat.com>
To: Nick Dokos <nicholas.dokos@hp.com>
Cc: linux-ext4@vger.kernel.org, "Theodore Ts'o" <tytso@mit.edu>
Subject: Re: [PATCH 4/6] [64-bit] enable dumpe2fs 64-bitness and fix printf formats.
Date: Mon, 4 May 2009 02:21:14 -0400 [thread overview]
Message-ID: <20090504062114.GF9151@shell> (raw)
In-Reply-To: <15579.1241167627@gamaville.dokosmarshall.org>
On Fri, May 01, 2009 at 04:47:07AM -0400, Nick Dokos wrote:
> Add EXT2_FLAG_NEW_BITMAPS to the ext2fs_open() flags.
>
> Change signature of print_range(): both arguments of the range
> are now unsigned long long, with the concomitant change to the
> printf formats.
>
> Signed-off-by: Nick Dokos <nicholas.dokos@hp.com>
> ---
> misc/dumpe2fs.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/misc/dumpe2fs.c b/misc/dumpe2fs.c
> index 8a746ee..4d5c90e 100644
> --- a/misc/dumpe2fs.c
> +++ b/misc/dumpe2fs.c
> @@ -63,12 +63,12 @@ static void print_number(unsigned long num)
> printf("%lu", num);
> }
>
> -static void print_range(unsigned long a, unsigned long b)
> +static void print_range(unsigned long long a, unsigned long long b)
> {
> if (hex_format)
> - printf("0x%04lx-0x%04lx", a, b);
> + printf("0x%llx-0x%llx", a, b);
> else
> - printf("%lu-%lu", a, b);
> + printf("%llu-%llu", a, b);
> }
>
> static void print_free (unsigned long group, char * bitmap,
> @@ -481,7 +481,7 @@ int main (int argc, char ** argv)
> if (optind > argc - 1)
> usage();
> device_name = argv[optind++];
> - flags = EXT2_FLAG_JOURNAL_DEV_OK | EXT2_FLAG_SOFTSUPP_FEATURES;
> + flags = EXT2_FLAG_JOURNAL_DEV_OK | EXT2_FLAG_SOFTSUPP_FEATURES | EXT2_FLAG_NEW_BITMAPS;
> if (force)
> flags |= EXT2_FLAG_FORCE;
> if (image_dump)
> --
> 1.6.0.6
>
Signed-off-by: Valerie Aurora (Henson) <vaurora@redhat.com>
-VAL
prev parent reply other threads:[~2009-05-04 6:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-01 8:47 [PATCH 4/6] [64-bit] enable dumpe2fs 64-bitness and fix printf formats Nick Dokos
2009-05-04 6:21 ` Valerie Aurora [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090504062114.GF9151@shell \
--to=vaurora@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=nicholas.dokos@hp.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.