All of lore.kernel.org
 help / color / mirror / Atom feed
From: Valerie Aurora <vaurora@redhat.com>
To: Nick Dokos <nicholas.dokos@hp.com>
Cc: linux-ext4@vger.kernel.org, "Theodore Ts'o" <tytso@mit.edu>
Subject: Re: [PATCH 5/6] [64-bit] (blk_t) cast in ext2fs_new_block2()
Date: Mon, 4 May 2009 02:21:24 -0400	[thread overview]
Message-ID: <20090504062124.GG9151@shell> (raw)
In-Reply-To: <15586.1241167637@gamaville.dokosmarshall.org>

On Fri, May 01, 2009 at 04:47:17AM -0400, Nick Dokos wrote:
> Found by code inspection after similar gratuitous cast in
> ext2fs_get_free_blocks2() (first patch in this series).
> 
> Signed-off-by: Nick Dokos <nicholas.dokos@hp.com>
> ---
>  lib/ext2fs/alloc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/ext2fs/alloc.c b/lib/ext2fs/alloc.c
> index 9f11673..a7c8860 100644
> --- a/lib/ext2fs/alloc.c
> +++ b/lib/ext2fs/alloc.c
> @@ -170,7 +170,7 @@ errcode_t ext2fs_new_block2(ext2_filsys fs, blk64_t goal,
>  					   (i - fs->super->s_first_data_block) /
>  					   EXT2_BLOCKS_PER_GROUP(fs->super));
>  
> -		if (!ext2fs_fast_test_block_bitmap2(map, (blk_t) i)) {
> +		if (!ext2fs_fast_test_block_bitmap2(map, i)) {
>  			*ret = i;
>  			return 0;
>  		}
> -- 
> 1.6.0.6
> 

Signed-off-by: Valerie Aurora (Henson) <vaurora@redhat.com>

-VAL

      reply	other threads:[~2009-05-04  6:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-01  8:47 [PATCH 5/6] [64-bit] (blk_t) cast in ext2fs_new_block2() Nick Dokos
2009-05-04  6:21 ` Valerie Aurora [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090504062124.GG9151@shell \
    --to=vaurora@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=nicholas.dokos@hp.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.