From: Oliver Neukum <oliver@neukum.org>
To: Li Hong <lihong.hi@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: use memdup_user()
Date: Mon, 4 May 2009 08:54:03 +0200 [thread overview]
Message-ID: <200905040854.03329.oliver@neukum.org> (raw)
In-Reply-To: <3a3680030905032038h40cd75bdrbee839117e5a4d55@mail.gmail.com>
Am Montag, 4. Mai 2009 05:38:33 schrieb Li Hong:
> The key is: is there any need or probability to use GFP_NOIO instead
> of GFP_KERNEL _here_? It also confuses me to move the user space copy
> outside of the loop.
No. To make it plain. To me any use of memdup_user() in USB code
is a bad idea. I don't want to have to think about a new primitive.
Regards
Oliver
next prev parent reply other threads:[~2009-05-04 6:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-03 16:00 [PATCH] usb: use memdup_user() Li Hong
2009-05-03 16:28 ` Oliver Neukum
2009-05-03 17:09 ` Oliver Neukum
2009-05-04 3:38 ` Li Hong
2009-05-04 6:54 ` Oliver Neukum [this message]
2009-05-04 7:02 ` David Brownell
2009-05-04 7:41 ` Pekka Enberg
2009-05-04 14:53 ` Greg KH
2009-05-04 15:13 ` Li Hong
2009-05-05 8:50 ` Oliver Neukum
2009-05-04 14:01 ` Oliver Neukum
2009-05-05 6:11 ` Andrew Morton
2009-05-05 10:44 ` Oliver Neukum
2009-05-05 17:22 ` Andrew Morton
2009-05-06 13:34 ` Oliver Neukum
2009-05-06 18:31 ` Andrew Morton
2009-05-06 18:44 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905040854.03329.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=lihong.hi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.