From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: Re: [PATCH] ioemu: Fixes for build/install system Date: Mon, 4 May 2009 11:42:37 +0200 Message-ID: <200905041142.37944.Christoph.Egger@amd.com> References: <200903311422.14692.Christoph.Egger@amd.com> <200904240834.42662.Christoph.Egger@amd.com> <18936.29351.248767.431837@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Boundary-00=_Nir/JrGV4HIABFX" Return-path: In-Reply-To: <18936.29351.248767.431837@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: "xen-devel@lists.xensource.com" , Keir Fraser List-Id: xen-devel@lists.xenproject.org --Boundary-00=_Nir/JrGV4HIABFX Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline On Wednesday 29 April 2009 17:30:47 Ian Jackson wrote: > Christoph Egger writes ("Re: [Xen-devel] Re: [PATCH] ioemu: Fixes for build/install system"): > > Can you send me the output of > > find dist/install ? Then I can tell you. > > I don't have it to hand but stuff had moved into usr/local from usr, > possibly amongst other changes. > > > Did you set PREFIX explicitely or did you use the default values ? > > I did not set PREFIX. > > > > Did you do a similar test ? > > > > I run my tests with clean rebuilds from the toplevel xen directory with > > gmake dist or PREFIX="/usr/local" gmake dist > > The purpose of your changes is to plumb PREFIX through to the qemu > build system. But I think you should also test that a default build > remains unchanged. I figured out why a default build installs ioemu into /usr/local with my patch: PREFIX is empty and ioemu's configure sets prefix to /usr/local if prefix is empty. Attached patch fixes this (and applies to the xen-tree). It always passes PREFIX to xen-setup and xen-setup-stubdom. Signed-off-by: Christoph Egger -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 --Boundary-00=_Nir/JrGV4HIABFX Content-Type: text/x-diff; charset="iso-8859-1"; name="xen_ioemu_prefix.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="xen_ioemu_prefix.diff" diff -r f80cf52a4fb6 stubdom/Makefile --- a/stubdom/Makefile Thu Apr 30 14:34:15 2009 +0100 +++ b/stubdom/Makefile Mon May 04 11:35:03 2009 +0200 @@ -235,6 +235,8 @@ libxc-$(XEN_TARGET_ARCH)/libxenctrl.a li ioemu: cross-zlib cross-libpci libxc [ -f ioemu/config-host.mak ] || \ ( $(absolutify_xen_root); \ + PREFIX=$(PREFIX); \ + export PREFIX; \ cd ioemu ; \ LWIPDIR=$(CURDIR)/lwip-$(XEN_TARGET_ARCH) \ TARGET_CPPFLAGS="$(TARGET_CPPFLAGS)" \ diff -r f80cf52a4fb6 tools/Makefile --- a/tools/Makefile Thu Apr 30 14:34:15 2009 +0100 +++ b/tools/Makefile Mon May 04 11:35:03 2009 +0200 @@ -91,6 +94,8 @@ ioemu-dir-find: fi set -e; \ $(absolutify_xen_root); \ + PREFIX=$(PREFIX); \ + export PREFIX; \ cd ioemu-dir; \ ./xen-setup $(IOEMU_CONFIGURE_CROSS) --Boundary-00=_Nir/JrGV4HIABFX Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --Boundary-00=_Nir/JrGV4HIABFX--