All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarod Wilson <jarod@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH] crypto: don't raise alarm for no ctr(aes*) tests in fips mode
Date: Mon, 4 May 2009 14:56:58 -0400	[thread overview]
Message-ID: <200905041456.59427.jarod@redhat.com> (raw)
In-Reply-To: <20090504111010.GA4991@gondor.apana.org.au>

On Monday 04 May 2009 07:10:10 Herbert Xu wrote:
> On Tue, Apr 28, 2009 at 09:18:22PM -0400, Jarod Wilson wrote:
> > Per the NIST AESAVS document, Appendix A[1], it isn't possible to
> > have automated self-tests for counter-mode AES, but people are
> > misled to believe something is wrong by the message that says there
> > is no test for ctr(aes). Simply suppress all 'no test for ctr(aes*'
> > messages if fips_enabled is set to avoid confusion.
> 
> This is not true at all.  In our implementation the counter is
> set through the IV so it definitely is possible to test counter
> mode algorithms in Linux.

Ah... Now I think I see... We can provide an initial counter w/o a
problem, but counter incrementation is implementation-specific, so
we can't have automated tests that cover multiple enc/dec ops, but
if we limit ourselves to just one op, self-tests should be perfectly
doable, and NIST SP 800-38A, Appendix F.5 has vectors we could make
use of (using just the block #1 values). At least, spot-checking
the vectors, I'm getting the expected results for the 1st block.

Okay, I'll whip something up in a sec.

-- 
Jarod Wilson
jarod@redhat.com

  reply	other threads:[~2009-05-04 18:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-29  1:18 [PATCH] crypto: don't raise alarm for no ctr(aes*) tests in fips mode Jarod Wilson
2009-04-29 10:50 ` Neil Horman
2009-04-29 12:46   ` Jarod Wilson
2009-04-30 21:13     ` [PATCH v2] crypto: don't raise alarm for no ctr(aes) tests Jarod Wilson
2009-05-01 11:54       ` Neil Horman
2009-05-04 11:10 ` [PATCH] crypto: don't raise alarm for no ctr(aes*) tests in fips mode Herbert Xu
2009-05-04 18:56   ` Jarod Wilson [this message]
2009-05-05  1:08     ` Herbert Xu
2009-05-05  3:45       ` Jarod Wilson
2009-05-05  5:29         ` Herbert Xu
2009-05-05 13:04           ` Jarod Wilson
2009-05-04 20:24   ` [PATCH] crypto: add ctr(aes) test vectors Jarod Wilson
2009-05-05 13:18     ` Herbert Xu
2009-05-05 13:55       ` Jarod Wilson
2009-05-05 14:42         ` [PATCH v2] " Jarod Wilson
2009-05-06  9:30           ` Herbert Xu
2009-05-06 12:51             ` Jarod Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905041456.59427.jarod@redhat.com \
    --to=jarod@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.