* Adrian Hunter [090504 01:27]: > Tony Lindgren wrote: >> * Tony Lindgren [090430 07:06]: >>> * vimal singh [090429 23:33]: >>>> 'gpmc-onenand.c' is still confusing name. This is not going to used in >>>> all boards anyway. >>> Why do you think this cannot be used for all boards? >>> >>> The GPMC timings are totally based on the onenand chip features. >> >> And these two patches make omap3430sdp to work with the gpmc-onenand >> code. Sync mode does not work, but it seems like it was never enabled >> for sdp anyways. >> >> Similar patch should work for other boards too. >> >> Tony >> > > This is not quite right. OneNAND only allows 3 possibilities: > > 1. Async: call 'omap2_onenand_set_async_mode()' > > 2. Sync Read: call 'omap2_onenand_set_sync_mode()' but force 'sync_write' variable to be always zero > > 3. Sync Read and Sync Write: call 'omap2_onenand_set_sync_mode()' as now Thanks. I take it that you mean that we need to leave out the sync write option from the possible combinations. Here's the updated version, let me know if you had something else in mind. This patch also moves the cpu_is_24xx() test to the init. Regards, Tony