From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Shane Dixon <shane.dixon-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: Moving to new driver model: probe never called
Date: Mon, 4 May 2009 18:10:20 +0200 [thread overview]
Message-ID: <20090504181020.62d1d413@hyperion.delvare> (raw)
In-Reply-To: <1241205250.31476.86.camel@homestead>
Hi Shane,
On Fri, 01 May 2009 13:14:10 -0600, Shane Dixon wrote:
> Thank you for the help. This is only my 2nd driver I've ever written
> (the first one being the i2c legacy version of the same driver!) I
> think that did it. The device is a tpm, but the I2C_CLASS_HWMON seems
> to help it get a little farther to the detect function.
Might be acceptable for your local testing, but obviously not for
upstream submission.
> I also had to
> make sure I had the normal_i2c[] struct present because I know the
> device listens on 0x29. This isn't something I can modify the
> board_info for because it's just wires jumping the device over to a
> development board (for a demo), so it's not permanently soldered on. I
> don't think it would be correct to use the board_info to treat it like a
> static device.
OK, that makes sense. I have just added a sysfs interface to handle
this situation more gracefully. I'll Cc you when I post it (in a
minute), please give it a try if you can.
--
Jean Delvare
http://khali.linux-fr.org/wishlist.html
prev parent reply other threads:[~2009-05-04 16:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-01 15:56 Moving to new driver model: probe never called Shane Dixon
2009-05-01 17:51 ` Jean Delvare
[not found] ` <20090501195146.4da8edf5-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-05-01 19:14 ` Shane Dixon
2009-05-04 16:10 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090504181020.62d1d413@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=shane.dixon-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.