From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [RFC][PATCH 04/36] btrfs: Add checkpoint file operations Date: Mon, 4 May 2009 16:41:46 -0500 Message-ID: <20090504214146.GA31338@us.ibm.com> References: <63ff4e88102e10e86bffefd5e4445ab433ed51c0.1241462097.git.matthltc@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Matt Helsley Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: containers.vger.kernel.org Quoting Matt Helsley (matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org): ... > diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c > index a7acfe6..f16be9d 100644 > --- a/fs/btrfs/super.c > +++ b/fs/btrfs/super.c > @@ -686,6 +686,7 @@ static const struct file_operations btrfs_ctl_fops = { > .unlocked_ioctl = btrfs_control_ioctl, > .compat_ioctl = btrfs_control_ioctl, > .owner = THIS_MODULE, > + .checkpoint = generic_file_checkpoint, > }; Do we really want this one? -serge