From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Sheng Yang <sheng@linux.intel.com>, Avi Kivity <avi@redhat.com>,
kvm@vger.kernel.org
Subject: Re: qemu/hw/device-assignment: questions about msix_table_page
Date: Tue, 5 May 2009 07:19:45 -0300 [thread overview]
Message-ID: <20090505101945.GA11426@amt.cnet> (raw)
In-Reply-To: <20090505095136.GA12797@redhat.com>
On Tue, May 05, 2009 at 12:51:36PM +0300, Michael S. Tsirkin wrote:
> On Mon, Apr 27, 2009 at 10:30:17PM +0800, Sheng Yang wrote:
> > > > > > If guest can write to the real device MSI-X table directly, it would
> > > > > > cause chaos on interrupt delivery, for what guest see is totally
> > > > > > different with what's host see...
> > > > >
> > > > > Obviously.
> > > > >
> > > > > Thanks,
> >
>
> What's the reason that this page is unmapped from the qemu memory space?
> Specifically what do these lines do:
> int offset = r_dev->msix_table_addr - real_region->base_addr;
> ret = munmap(region->u.r_virtbase + offset, TARGET_PAGE_SIZE);
I believe this allows accesses to this page (the MSI-X table), which
is part of the guest address space (through kvm memory slots), to be
trapped by qemu.
Since there is no actual page in this guest address, KVM treats accesses
as MMIO and forwards them to QEMU.
next prev parent reply other threads:[~2009-05-05 10:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090427104117.GB29082@redhat.com>
2009-04-27 13:16 ` Sheng Yang
2009-04-27 13:51 ` qemu/hw/device-assignment: questions about msix_table_page Michael S. Tsirkin
2009-04-27 14:03 ` Sheng Yang
2009-04-27 14:15 ` Michael S. Tsirkin
2009-04-27 14:30 ` Sheng Yang
2009-04-27 14:35 ` Michael S. Tsirkin
2009-05-05 9:51 ` Michael S. Tsirkin
2009-05-05 10:19 ` Marcelo Tosatti [this message]
2009-05-05 10:34 ` Michael S. Tsirkin
2009-05-05 10:49 ` Marcelo Tosatti
2009-05-05 11:45 ` Michael S. Tsirkin
2009-05-05 11:51 ` Marcelo Tosatti
2009-05-05 12:46 ` Michael S. Tsirkin
2009-05-06 2:35 ` Sheng Yang
2009-05-06 7:31 ` Michael S. Tsirkin
2009-05-06 8:17 ` Sheng Yang
2009-04-28 9:31 ` Avi Kivity
2009-04-27 13:13 Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090505101945.GA11426@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.