From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: KVM_ASSIGN_SET_MSIX_NR and KVM_ASSIGN_SET_MSIX_ENTRY should
	support MSI?
Date: Tue, 5 May 2009 08:04:15 -0300
Message-ID: <20090505110415.GA4114@amt.cnet>
References: <20090505103028.GA15418@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Sheng Yang <sheng@linux.intel.com>, Avi Kivity <avi@redhat.com>,
	Matthew Wilcox <willy@linux.intel.com>, kvm@vger.kernel.org
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:33000 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752748AbZEELEb (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 5 May 2009 07:04:31 -0400
Content-Disposition: inline
In-Reply-To: <20090505103028.GA15418@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, May 05, 2009 at 01:30:28PM +0300, Michael S. Tsirkin wrote:
> The new KVM_ASSIGN_SET_MSIX_NR and KVM_ASSIGN_SET_MSIX_ENTRY ioctls have
> been merged for 2.6.30. However, I note that PCI spec allows devices to
> support multiple vectors with MSI as well (support will be in linux
> 2.6.30).
> 
> Even though qemu for now only uses a single vector with MSI, it would
> seem that it's better to make the kernel/user interface generic straight
> away rather than add more ioctls later. What do you think? It might not
> be too late to fix this for 2.6.30.

Can't you use more than one KVM_ASSIGN_SET_MSIX_ENTRY call per assigned
device?

If you can't, it would be better to change the ioctls before 2.6.30 is
release IMO.