From: Christoph Hellwig <hch@infradead.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Christoph Hellwig <hch@infradead.org>,
Alessio Igor Bogani <abogani@texware.it>,
Jonathan Corbet <corbet@lwn.net>,
Fr??d??ric Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
LKML <linux-kernel@vger.kernel.org>,
LFSDEV <linux-fsdevel@vger.kernel.org>,
Matthew Wilcox <matthew@wil.cx>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH vfs-2.6:for-next] vfs: remount_fs BKL pushdown
Date: Wed, 6 May 2009 02:26:30 -0400 [thread overview]
Message-ID: <20090506062630.GA28560@infradead.org> (raw)
In-Reply-To: <20090506035138.GP8633@ZenIV.linux.org.uk>
On Wed, May 06, 2009 at 04:51:38AM +0100, Al Viro wrote:
> Actually, I'm not sure that you are right. Especially if we go for your
> "always hold s_umount for sync_filesystem()"; in that case we are guaranteed
> that we'll have an exclusion between ->write_super() and that sucker, so
> there's no reason to push it down into filesystems that do not use lock_super()
The interesting cases are locking against internal s_lock which at least
extN needs or ->write_super. And I'd really be rather safe than sorry
and audit individual filesystems than introducing bug in an obscure one.
next prev parent reply other threads:[~2009-05-06 6:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-25 8:09 [PATCH vfs-2.6:for-next] vfs: remount_fs BKL pushdown Alessio Igor Bogani
2009-04-25 8:23 ` Christoph Hellwig
2009-05-05 13:37 ` Christoph Hellwig
2009-05-05 19:39 ` Alessio Igor Bogani
2009-05-05 19:39 ` Alessio Igor Bogani
2009-05-05 20:43 ` Christoph Hellwig
2009-05-06 3:51 ` Al Viro
2009-05-06 6:26 ` Christoph Hellwig [this message]
2009-05-06 6:48 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090506062630.GA28560@infradead.org \
--to=hch@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=abogani@texware.it \
--cc=corbet@lwn.net \
--cc=fweisbec@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mingo@elte.hu \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.