All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>, linux-fsdevel@vger.kernel.org
Subject: Re: [PTCH] push down lock_super and BKL into ->put_super
Date: Wed, 6 May 2009 03:34:29 -0400	[thread overview]
Message-ID: <20090506073429.GC6976@mit.edu> (raw)
In-Reply-To: <20090506064622.GQ8633@ZenIV.linux.org.uk>

On Wed, May 06, 2009 at 07:46:22AM +0100, Al Viro wrote:
> 
> FS blocking writeback may very well be, though.
> 
> In any case, the point is that we should separate get_fs_excl() from
> exclusion there and kill exclusion part for everything except ext4.

Note that I already have patches queued for ext4 that removes the use
of lock_super() for everything other than write_super() exclusion.
(i.e., we were using it to protect oneline resize and the orphan
list.)  Similar patches are needed for ext3, which I'll backport
before the next merge window.

BTW, I'm *not* at all convinced that get_fs_excl() is the right
interface for boosting I/O priority, since it only boosts priority for
idle processes.  So high priority processes will still get screwed by
normal I/O.  Hence, in the common case, where there are no I/O class
nince processes, get_fs_excl() is a no-op anyway.  And the case which
I'm personally most interested in, which is real-time processes that
want to do I/O and so have an elevated I/O priority, get_fs_excl()
does nothing for them.

						- Ted

      reply	other threads:[~2009-05-06  7:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-05 13:40 [PTCH] push down lock_super and BKL into ->put_super Christoph Hellwig
2009-05-06  2:09 ` Al Viro
2009-05-06  6:23   ` Christoph Hellwig
2009-05-06  6:46     ` Al Viro
2009-05-06  7:34       ` Theodore Tso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090506073429.GC6976@mit.edu \
    --to=tytso@mit.edu \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.