All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konstantinos Margaritis <markos@codex.gr>
To: linux-ide@vger.kernel.org
Subject: [PATCH] fix sata_sil compilation on non-DMI platforms
Date: Wed, 6 May 2009 20:09:27 +0300	[thread overview]
Message-ID: <200905062009.28087.markos@codex.gr> (raw)

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

(not subscribed please CC me)

I tried to compile sata_sil on a 2.6.27 kernel on powerpc32 and I found that 
it failed to compile -lots of dmi related errors. I found that I had to 
include the broken_systems handling code in #ifdef CONFIG_DMI (DMI is not 
supported on platforms other than i386/x86_64). 

Lennert on #mklinux told me that this commit broke the non-dmi support, and 
that a similar patch to mine is used on ARM systems :

commit e57db7bde7bff95ae812736ca00c73bd5271455b
SATA Sil: Blacklist system that spins off disks during ACPI power off

With this patch, sata_sil compiles on ppc (and I guess on other platforms). 
I'm using it for a while with no problems with a Delock 4-port SATA PCI card.

Regards

-- 
Konstantinos Margaritis
Codex
http://www.codex.gr

[-- Attachment #2: sata_sil.c.patch --]
[-- Type: text/x-patch, Size: 458 bytes --]

--- sata_sil.c.orig	2009-05-06 20:03:16.472876188 +0300
+++ sata_sil.c	2009-05-06 20:04:22.693209638 +0300
@@ -698,6 +698,7 @@
 
 static bool sil_broken_system_poweroff(struct pci_dev *pdev)
 {
+#ifdef CONFIG_DMI
 	static const struct dmi_system_id broken_systems[] = {
 		{
 			.ident = "HP Compaq nx6325",
@@ -718,7 +719,7 @@
 		/* apply the quirk only to on-board controllers */
 		return slot == PCI_SLOT(pdev->devfn);
 	}
-
+#endif
 	return false;
 }
 

             reply	other threads:[~2009-05-06 17:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-06 17:09 Konstantinos Margaritis [this message]
2009-05-11 18:12 ` [PATCH] fix sata_sil compilation on non-DMI platforms Jeff Garzik
2009-05-11 18:23   ` Lennert Buytenhek
2009-05-11 18:44   ` Alan Cox
2009-05-11 18:44     ` Alan Cox
2009-05-11 22:31     ` Benjamin Herrenschmidt
2009-05-11 19:30   ` Lennart Sorensen
2009-05-12  9:09   ` Mikael Pettersson
2009-05-12  9:26     ` Jeff Garzik
2009-05-15 11:11       ` Mikael Pettersson
2009-05-15 17:49         ` Jeff Garzik
2009-05-15 22:46           ` Mikael Pettersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905062009.28087.markos@codex.gr \
    --to=markos@codex.gr \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.