From: "Michael S. Tsirkin" <mst@redhat.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: mtosatti@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com
Subject: [Qemu-devel] Re: pci_default_config_write() clean up.
Date: Thu, 7 May 2009 12:34:50 +0300 [thread overview]
Message-ID: <20090507093450.GE32039@redhat.com> (raw)
In-Reply-To: <20090507090639.GB25512%yamahata@valinux.co.jp>
On Thu, May 07, 2009 at 06:06:39PM +0900, Isaku Yamahata wrote:
> On Thu, May 07, 2009 at 11:50:10AM +0300, Michael S. Tsirkin wrote:
> > Hmm, this adds more code that it removes.
> > Did you take a look at my attempt at the rewrite of the same function?
>
> Yes, so I added you on Cc.
> The most of code is trivial tables,
> so I don't think it complicates the logic.
Well, one still needs to wade through them to figure out
how things work.
> If we want more precise emulation, your pci_init_mask()
> will bigger anyway.
The diffstat for both patches tells a different story :)
--
MST
next prev parent reply other threads:[~2009-05-07 9:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 8:40 [Qemu-devel] pci_default_config_write() clean up Isaku Yamahata
2009-05-07 8:50 ` [Qemu-devel] " Michael S. Tsirkin
2009-05-07 9:06 ` Isaku Yamahata
2009-05-07 9:34 ` Michael S. Tsirkin [this message]
2009-05-07 9:29 ` Michael S. Tsirkin
2009-05-07 9:55 ` Isaku Yamahata
2009-05-07 10:25 ` Michael S. Tsirkin
2009-05-07 11:13 ` Isaku Yamahata
2009-05-07 11:46 ` Michael S. Tsirkin
2009-05-07 11:57 ` Paul Brook
-- strict thread matches above, loose matches on Subject: below --
2009-05-08 3:43 [Qemu-devel] " Isaku Yamahata
2009-05-08 14:21 ` [Qemu-devel] " Michael S. Tsirkin
2009-05-10 8:38 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090507093450.GE32039@redhat.com \
--to=mst@redhat.com \
--cc=armbru@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.