All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Andi Kleen <andi@firstfloor.org>,
	Huang Ying <ying.huang@intel.com>, Li Wei <W.Li@Sun.COM>,
	Michael Ellerman <michaele@au1.ibm.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Sam Ravnborg <sam@ravnborg.org>, Jeff Dike <jdike@addtoit.com>
Subject: Re: [PATCH 1/4] kernel: constructor support
Date: Thu, 7 May 2009 14:51:07 +0200	[thread overview]
Message-ID: <20090507125107.GL28398@elte.hu> (raw)
In-Reply-To: <20090507124557.003153444@linux.vnet.ibm.com>


* Peter Oberparleiter <oberpar@linux.vnet.ibm.com> wrote:

> +typedef void (*ctorcall_t)(void);

that name is pretty ugly. Please change it to the usual kernel 
convention for function pointers:

	typedef void (*ctor_fn_t)(void);

Thanks,

	Ingo

  reply	other threads:[~2009-05-07 12:52 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-07 12:45 [PATCH 0/4] gcov kernel support Peter Oberparleiter
2009-05-07 12:45 ` [PATCH 1/4] kernel: constructor support Peter Oberparleiter
2009-05-07 12:51   ` Ingo Molnar [this message]
2009-05-07 13:33     ` Peter Oberparleiter
2009-05-07 12:53   ` Ingo Molnar
2009-05-07 13:38     ` Peter Oberparleiter
2009-05-07 13:48       ` Ingo Molnar
2009-05-08 11:23         ` Peter Oberparleiter
2009-05-07 12:45 ` [PATCH 2/4] seq_file: add function to write binary data Peter Oberparleiter
2009-05-07 12:45 ` [PATCH 3/4] gcov: add gcov profiling infrastructure Peter Oberparleiter
2009-05-07 13:46   ` Ingo Molnar
2009-05-07 13:49     ` Ingo Molnar
2009-05-08 11:10     ` Peter Oberparleiter
2009-05-11 13:17       ` Ingo Molnar
2009-05-12 13:09         ` Peter Oberparleiter
2009-05-12 13:35           ` Ingo Molnar
2009-05-07 12:46 ` [PATCH 4/4] gcov: enable GCOV_PROFILE_ALL for x86_64 Peter Oberparleiter
  -- strict thread matches above, loose matches on Subject: below --
2009-06-02 11:43 [PATCH 0/4] gcov kernel support Peter Oberparleiter
2009-06-02 11:44 ` [PATCH 1/4] kernel: constructor support Peter Oberparleiter
2009-06-02 21:32   ` Andrew Morton
2009-06-03 11:55     ` Peter Oberparleiter
2009-05-19 14:24 [PATCH 0/4] gcov kernel support Peter Oberparleiter
2009-05-19 14:24 ` [PATCH 1/4] kernel: constructor support Peter Oberparleiter
2009-05-12 15:38 [PATCH 0/4] gcov kernel support Peter Oberparleiter
2009-05-12 15:38 ` [PATCH 1/4] kernel: constructor support Peter Oberparleiter
2009-05-08 15:44 [PATCH 0/4] gcov kernel support Peter Oberparleiter
2009-05-08 15:44 ` [PATCH 1/4] kernel: constructor support Peter Oberparleiter
2009-05-09  5:03   ` Américo Wang
2009-05-11  8:43     ` Peter Oberparleiter
2009-05-11 18:54       ` Sam Ravnborg
2009-05-12 13:12         ` Peter Oberparleiter
2009-02-26 13:51 Peter Oberparleiter
2009-02-03 12:46 Peter Oberparleiter
2009-02-04  2:54 ` Rusty Russell
2009-02-04 15:05   ` Peter Oberparleiter
2009-02-04 23:23     ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090507125107.GL28398@elte.hu \
    --to=mingo@elte.hu \
    --cc=W.Li@Sun.COM \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=jdike@addtoit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michaele@au1.ibm.com \
    --cc=oberpar@linux.vnet.ibm.com \
    --cc=rusty@rustcorp.com.au \
    --cc=sam@ravnborg.org \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.