From: Andrew Morton <akpm@linux-foundation.org>
To: Harry Ciao <qingtao.cao@windriver.com>
Cc: norsk5@yahoo.com, bluesmoke-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [v0 PATCH 1/1] Use dev_name() for AMD8111/AMD8131 EDAC driver
Date: Thu, 7 May 2009 14:57:22 -0700 [thread overview]
Message-ID: <20090507145722.b2d89e11.akpm@linux-foundation.org> (raw)
In-Reply-To: <1241660858-21105-2-git-send-email-qingtao.cao@windriver.com>
On Thu, 7 May 2009 09:47:38 +0800
Harry Ciao <qingtao.cao@windriver.com> wrote:
> The device structure no longer has bus_id member, dev_name() should
> be used for AMD8111 & AMD8131 EDAC driver instead. Also, their Makefile
> entries are lost, add them.
>
> Signed-off-by: Harry Ciao <qingtao.cao@windriver.com>
> ---
> drivers/edac/Makefile | 2 ++
> drivers/edac/amd8111_edac.c | 4 ++--
> drivers/edac/amd8131_edac.c | 2 +-
> 3 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/edac/Makefile b/drivers/edac/Makefile
> index a5fdcf0..5907681 100644
> --- a/drivers/edac/Makefile
> +++ b/drivers/edac/Makefile
> @@ -35,3 +35,5 @@ obj-$(CONFIG_EDAC_MPC85XX) += mpc85xx_edac.o
> obj-$(CONFIG_EDAC_MV64X60) += mv64x60_edac.o
> obj-$(CONFIG_EDAC_CELL) += cell_edac.o
> obj-$(CONFIG_EDAC_PPC4XX) += ppc4xx_edac.o
> +obj-$(CONFIG_EDAC_AMD8111) += amd8111_edac.o
> +obj-$(CONFIG_EDAC_AMD8131) += amd8131_edac.o
hm, I wonder how that happened.
The drivers break x86-64 allmodconfig:
drivers/edac/amd8111_edac.c: In function 'amd8111_lpc_bridge_init':
drivers/edac/amd8111_edac.c:260: error: implicit declaration of function '__do_inb'
drivers/edac/amd8111_edac.c:274: error: implicit declaration of function '__do_outb'
next prev parent reply other threads:[~2009-05-07 22:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 1:47 [v0 PATCH 0/1] EDAC: Use dev_name() for AMD8111/AMD8131 drivers Harry Ciao
2009-05-07 1:47 ` [v0 PATCH 1/1] Use dev_name() for AMD8111/AMD8131 EDAC driver Harry Ciao
2009-05-07 21:57 ` Andrew Morton [this message]
2009-05-11 2:47 ` Harry Ciao
2009-05-11 3:57 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090507145722.b2d89e11.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bluesmoke-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=norsk5@yahoo.com \
--cc=qingtao.cao@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.