From: Andrew Morton <akpm@linux-foundation.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: gorcunov@openvz.org, kosaki.motohiro@jp.fujitsu.com,
mel@csn.ul.ie, cl@linux-foundation.org, riel@redhat.com,
linux-kernel@vger.kernel.org, mingo@elte.hu, rientjes@google.com
Subject: Re: [PATCH 1/2] mm: Introduce GFP_PANIC for early-boot allocations
Date: Fri, 8 May 2009 13:56:32 -0700 [thread overview]
Message-ID: <20090508135632.9c041339.akpm@linux-foundation.org> (raw)
In-Reply-To: <1241795428.28600.60.camel@penberg-laptop>
On Fri, 08 May 2009 18:10:28 +0300
Pekka Enberg <penberg@cs.helsinki.fi> wrote:
> +#define GFP_PANIC (__GFP_NOFAIL | __GFP_NORETRY)
urgh, you have to be kidding me. This significantly worsens complexity
and risk in core MM and it's just yuk.
I think we can justify pulling such dopey party tricks to save
pageframe space, or bits in page.flags and such. But just to save a
scrap of memory which would have been released during boot anwyay?
Don't think so.
I'd suggest panic_if_null(). Or just leave everything alone - it's
hardly a pressing problem.
next prev parent reply other threads:[~2009-05-08 21:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 15:10 [PATCH 1/2] mm: Introduce GFP_PANIC for early-boot allocations Pekka Enberg
2009-05-08 15:29 ` Christoph Lameter
2009-05-08 15:41 ` Pekka Enberg
2009-05-09 8:31 ` Ingo Molnar
2009-05-08 20:56 ` Andrew Morton [this message]
2009-05-09 8:39 ` Pekka Enberg
2009-05-09 9:19 ` Ingo Molnar
2009-05-09 9:19 ` Pekka Enberg
2009-05-09 9:31 ` Ingo Molnar
2009-05-09 9:32 ` Ingo Molnar
2009-05-10 3:34 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090508135632.9c041339.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=gorcunov@openvz.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.