From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jeff Mahoney <jeffm@suse.com>
Cc: Al Viro <viro@ftp.linux.org.uk>,
reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
stefanr@s5r6.in-berlin.de
Subject: Re: [patch 3/4] reiserfs: fixup perms when xattrs are disabled
Date: Sun, 10 May 2009 22:35:18 +0100 [thread overview]
Message-ID: <20090510213518.GG8633@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20090510200649.900586983@suse.com>
On Sun, May 10, 2009 at 04:05:38PM -0400, Jeff Mahoney wrote:
> +#ifdef CONFIG_REISERFS_FS_XATTR
> + /*
> + * Stat data v1 doesn't support ACLs.
> + */
> + if (get_inode_sd_version(inode) != STAT_DATA_V1)
> + return generic_permission(inode, mask, reiserfs_check_acl);
> + else
> +#endif
> + return generic_permission(inode, mask, NULL);
Matter of style: this kind of mixing the nesting structures is Not Nice(tm),
so I'd rather turn that into
+#ifdef CONFIG_REISERFS_FS_XATTR
+ /*
+ * Stat data v1 doesn't support ACLs.
+ */
+ if (get_inode_sd_version(inode) != STAT_DATA_V1)
+ return generic_permission(inode, mask, reiserfs_check_acl);
+#endif
+
+ return generic_permission(inode, mask, NULL);
next prev parent reply other threads:[~2009-05-10 21:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-10 20:05 [patch 0/4] reiserfs xattr fixups Jeff Mahoney
2009-05-10 20:05 ` [patch 1/4] reiserfs: clean up ifdefs Jeff Mahoney
2009-05-10 20:05 ` [patch 2/4] [PATCH] reiserfs: deal with NULL xattr root w/ xattrs disabled Jeff Mahoney
2009-05-10 20:05 ` [patch 3/4] reiserfs: fixup perms when xattrs are disabled Jeff Mahoney
2009-05-10 21:35 ` Al Viro [this message]
2009-05-10 23:28 ` Jeff Mahoney
2009-05-10 20:05 ` [patch 4/4] reiserfs: allow exposing privroot w/ xattrs enabled Jeff Mahoney
2009-05-10 21:34 ` [patch 0/4] reiserfs xattr fixups Stefan Richter
-- strict thread matches above, loose matches on Subject: below --
2009-05-17 5:02 [patch 0/4] Reiserfs fixes Jeff Mahoney
2009-05-17 5:02 ` [patch 3/4] reiserfs: fixup perms when xattrs are disabled Jeff Mahoney
2009-05-17 11:50 ` Stefan Richter
2009-05-17 13:59 ` Jeff Mahoney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090510213518.GG8633@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=jeffm@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.