All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] net/dm9000: move the CONFIG_NET_MULTI api
Date: Mon, 11 May 2009 14:02:54 -0400	[thread overview]
Message-ID: <200905111402.56581.vapier@gentoo.org> (raw)
In-Reply-To: <1242023969-13542-3-git-send-email-plagnioj@jcrosoft.com>

On Monday 11 May 2009 02:39:28 Jean-Christophe PLAGNIOL-VILLARD wrote:
> this add multi devices support and merge dm9000's eeprom command support

assuming this doesnt depend on the first two patches in this series, this 
sounds great to me

> +U_BOOT_CMD(
> +	dm9000ee,4,1,do_dm9000_eeprom,
> +	"Read/Write eeprom connected to Ethernet Controller",
> +	"\ndm9000ee write <name> <word offset> <value> \n"
> +	"\tdm9000ee read <name>\n"
> +	"\tword:\t\t00-02 : MAC Address\n"
> +	"\t\t\t03-07 : DM9000 Configuration\n"
> +	"\t\t\t08-63 : User data\n");

the usage is slightly damaged in the original ... be nice to not copy over 
that broken crap.  i.e. it should look like:
	"write <name> <word offset> <value>\n"
	"dm9000ee read <name>\n"
	"\tword:\t\t00-02 : MAC Address\n"
	"\t\t\t03-07 : DM9000 Configuration\n"
	"\t\t\t08-63 : User data\n");

> +int dm9000_eth_initialize(int id, u32 *data_addr, u32 *io_addr);

requiring the data and io addr to be 32bit aligned is not a real requirement 
is it ?  so perhaps it should be void* here instead of u32*.
-mike

  parent reply	other threads:[~2009-05-11 18:02 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-11  6:39 [U-Boot] [PATCH 1/4] net: extend the netdev to have a common way to set the hw mac address Jean-Christophe PLAGNIOL-VILLARD
2009-05-11  6:39 ` [U-Boot] [PATCH 2/4] macb: add set_hw_enetaddr support Jean-Christophe PLAGNIOL-VILLARD
2009-05-11  6:39   ` [U-Boot] [PATCH 3/4] net/dm9000: move the CONFIG_NET_MULTI api Jean-Christophe PLAGNIOL-VILLARD
2009-05-11  6:39     ` [U-Boot] [PATCH 4/4] at91/macb: remove reset_phy callback Jean-Christophe PLAGNIOL-VILLARD
2009-05-12  0:31       ` Ben Warren
2009-05-11 18:02     ` Mike Frysinger [this message]
2009-05-11 23:58       ` [U-Boot] [PATCH 3/4] net/dm9000: move the CONFIG_NET_MULTI api Jean-Christophe PLAGNIOL-VILLARD
2009-05-12  0:37         ` Mike Frysinger
2009-05-12  0:30     ` Ben Warren
2009-05-11  9:13   ` [U-Boot] [PATCH 2/4] macb: add set_hw_enetaddr support Haavard Skinnemoen
2009-05-12  0:29   ` Ben Warren
2009-05-11  7:48 ` [U-Boot] [PATCH 1/4] net: extend the netdev to have a common way to set the hw mac address Mike Frysinger
2009-05-11 12:08   ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-11 13:26     ` Wolfgang Denk
2009-05-11 14:24       ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-11 16:01         ` Wolfgang Denk
2009-05-11 16:30           ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-11 16:24         ` Mike Frysinger
2009-05-11 16:37           ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-11 16:56             ` Mike Frysinger
2009-05-12  0:04               ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-12  0:36                 ` Mike Frysinger
2009-05-12  8:48                   ` Detlev Zundel
2009-05-12 12:26                     ` Mike Frysinger
2009-05-12 14:18                       ` Detlev Zundel
2009-05-12 16:21                         ` Daniel Stenberg
2009-05-12 22:06                         ` Mike Frysinger
2009-05-13  8:41                           ` Detlev Zundel
2009-05-13 18:07                             ` Mike Frysinger
2009-05-15 14:42                               ` Detlev Zundel
2009-05-12 16:59                     ` Scott Wood
2009-05-13  8:39                       ` Detlev Zundel
2009-05-12 17:02                 ` Scott Wood
2009-05-11 17:49             ` Wolfgang Denk
2009-05-11 17:24           ` Mike Frysinger
2009-05-11 17:54             ` Wolfgang Denk
2009-05-12  0:28 ` Ben Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905111402.56581.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.