All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH 0/4] gitweb: Some code cleanups, part 2 (low hanging fruit)
Date: Mon, 11 May 2009 19:36:26 +0200	[thread overview]
Message-ID: <20090511173025.15152.94215.stgit@localhost.localdomain> (raw)

The following series was inspired by severity: 3 Perl::Critic
(http://perlcritic.com) suggestions for gitweb; the patches listed
below are simple and obvious fixes.  That is why there is no detailed
explanation of perlcritic policy for each patch.

This time I have checked that t9500 passes...
---
Jakub Narebski (4):
  gitweb: Remove unused $hash_base parameter from normalize_link_target
  gitweb: Simplify snapshot format detection logic in evaluate_path_info
  gitweb: Use capturing parentheses only when you intend to capture
  gitweb: Replace wrongly added tabs with spaces

 gitweb/gitweb.perl |   20 +++++++++-----------
 1 files changed, 9 insertions(+), 11 deletions(-)

-- 
Jakub Narebski
ShadeHawk on #git
Poland

             reply	other threads:[~2009-05-11 17:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-11 17:36 Jakub Narebski [this message]
2009-05-11 17:37 ` [PATCH 1/4] gitweb: Replace wrongly added tabs with spaces Jakub Narebski
2009-05-11 17:39 ` [PATCH 2/4] gitweb: Use capturing parentheses only when you intend to capture Jakub Narebski
2009-05-11 17:42 ` [PATCH 3/4] gitweb: Simplify snapshot format detection logic in evaluate_path_info Jakub Narebski
2009-05-11 17:52   ` Giuseppe Bilotta
2009-05-11 17:45 ` [PATCH 4/4] gitweb: Remove unused $hash_base parameter from normalize_link_target Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090511173025.15152.94215.stgit@localhost.localdomain \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.