From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [RFC 3/5] mac80211: fix idle trigger upon resume
Date: Mon, 11 May 2009 12:09:22 -0700 [thread overview]
Message-ID: <20090511190922.GD18696@tesla> (raw)
In-Reply-To: <1242068010.3873.46.camel@johannes.local>
On Mon, May 11, 2009 at 11:53:30AM -0700, Johannes Berg wrote:
> On Mon, 2009-05-11 at 11:34 -0700, Luis R. Rodriguez wrote:
>
> > > Also, __ieee80211_queues_stopped_by_reason is misnamed since it checks
> > > only a single queue. I also think that we can do this much better by
> > > keeping track of the suspend state in a new variable rather than looking
> > > at all the queues; even just checking queue 0 would be sufficient, but I
> > > think a new variable is warranted.
> >
> > A global variable for going to suspend? Hm, do we have a system wide
> > thing for this instead?
>
> No, and even then we couldn't use it I think since you can have
> per-device suspend. I was just thinking of a local->variable.
OK thanks will add this.
Luis
next prev parent reply other threads:[~2009-05-11 19:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 9:24 [RFC 0/5] mac80211 suspend cleanups/helpers Luis R. Rodriguez
2009-05-11 9:25 ` [RFC 1/5] ath9k: do not stop the queues in driver stop Luis R. Rodriguez
2009-05-11 9:25 ` [RFC 2/5] adm8211: remove uneeded code during suspend/resume Luis R. Rodriguez
2009-05-11 9:25 ` [RFC 3/5] mac80211: fix idle trigger upon resume Luis R. Rodriguez
2009-05-11 10:01 ` Johannes Berg
2009-05-11 18:34 ` Luis R. Rodriguez
2009-05-11 18:53 ` Johannes Berg
2009-05-11 19:09 ` Luis R. Rodriguez [this message]
2009-05-15 0:32 ` Luis R. Rodriguez
2009-05-15 1:33 ` Luis R. Rodriguez
2009-05-15 2:18 ` Luis R. Rodriguez
2009-05-15 8:01 ` Johannes Berg
2009-05-11 9:25 ` [RFC 4/5] mac80211: add a struct for info upon device stop Luis R. Rodriguez
2009-05-11 9:53 ` Johannes Berg
2009-05-11 18:33 ` Luis R. Rodriguez
2009-05-11 9:25 ` [RFC 5/5] ath9k: Add Wake-on-Wireless-LAN support Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090511190922.GD18696@tesla \
--to=lrodriguez@atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.