From: Theodore Tso <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Andreas Dilger <adilger@sun.com>,
Alexander Shishkin <alexander.shishckin@gmail.com>,
linux-ext4@vger.kernel.org
Subject: Re: [Q] ext3 mkfs: zeroing journal blocks
Date: Mon, 11 May 2009 15:35:14 -0400 [thread overview]
Message-ID: <20090511193514.GF21518@mit.edu> (raw)
In-Reply-To: <4A087202.4010601@redhat.com>
On Mon, May 11, 2009 at 01:44:18PM -0500, Eric Sandeen wrote:
> Andreas Dilger wrote:
>
> > The reason that the journal is zeroed is because there is some chance
> > that old (valid at the time) transaction headers and commit blocks might
> > be in the journal and could accidentally be "recovered" and cause bad
> > corruption of the filesystem.
>
> But I guess the question is, why isn't a normal internal log zeroed?
>
> If I'm reading it right only external logs get this treatment, and I
> think that's what generated the original question from Alexander.
Internal journals are indeed cleared. Check out write_journal_inode()
in lib/ext2fs/mkjournal.c, which calls ext2fs_block_iterate() passing
in the callback function mkjournal_proc(), which calls
ext2fs_zero_blocks().
- Ted
next prev parent reply other threads:[~2009-05-11 19:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 15:03 [Q] ext3 mkfs: zeroing journal blocks Alexander Shishkin
2009-05-11 17:58 ` Eric Sandeen
2009-05-11 18:20 ` Andreas Dilger
2009-05-11 18:44 ` Eric Sandeen
2009-05-11 19:35 ` Theodore Tso [this message]
2009-05-11 19:35 ` Andreas Dilger
2009-05-12 11:55 ` Alexander Shishkin
2009-05-12 12:13 ` Theodore Tso
2009-05-12 12:49 ` Alexander Shishkin
2009-05-12 21:04 ` Theodore Tso
2009-07-29 15:58 ` [PATCH] [RFC] mkjournal: zero journal blocks only when necessary Alexander Shishkin
2009-07-29 17:16 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090511193514.GF21518@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@sun.com \
--cc=alexander.shishckin@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.