From: Matthew Garrett <mjg59@srcf.ucam.org>
To: yakui_zhao <yakui.zhao@intel.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Witold Szczeponik <Witold.Szczeponik@gmx.net>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Len Brown <lenb@kernel.org>, Bjorn Helgaas <bjorn.helgaas@hp.com>,
"cedric@belbone.be" <cedric@belbone.be>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] ACPI: suspend: don't let device _PS3 failure prevent suspend
Date: Tue, 12 May 2009 03:50:17 +0100 [thread overview]
Message-ID: <20090512025017.GB24896@srcf.ucam.org> (raw)
In-Reply-To: <1242095172.3773.209.camel@localhost.localdomain>
On Tue, May 12, 2009 at 10:26:12AM +0800, yakui_zhao wrote:
> Windows can work well on such broken box. And I find that the _STA
> object of power resource is not called in course of power transition
> with the help of KVM.
>
> To be compatible with windows, we add such a
> workaround("acpi.power_nocheck=1") to fix this issue.
If Windows doesn't call _STA when performing these power transitions
then the default behaviour of Linux should be not to call _STA. We
strive to maintain compatibility with Windows when it comes to driving
the hardware - that means not forcing the user to add a boot option or
trying to maintain a DMI table.
> If the power state check is always skipped in course of power
> transition, there is no such error message. But it can't tell us that
> this is a broken BIOS.
Failing someone's suspend in order to inform them that their ancient
hardware has a broken BIOS doesn't seem like useful behaviour.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2009-05-12 2:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-13243-10286@http.bugzilla.kernel.org/>
[not found] ` <20090505150138.92f3ecd6.akpm@linux-foundation.org>
[not found] ` <4A02000D.9030400@gmx.net>
[not found] ` <200905061616.36707.bjorn.helgaas@hp.com>
2009-05-07 1:43 ` [Bugme-new] [Bug 13243] New: regression from 2.6.29 : can't suspend on a compaq nc6000, suspend_device(): pnp_bus_suspend+0x0/0x6b returns -5 yakui_zhao
2009-05-07 19:05 ` Witold Szczeponik
2009-05-08 1:31 ` yakui_zhao
2009-05-08 4:39 ` [PATCH] ACPI: suspend: don't let device _PS3 failure prevent suspend Len Brown
2009-05-08 12:23 ` Henrique de Moraes Holschuh
2009-05-10 20:48 ` Witold Szczeponik
2009-05-11 2:43 ` yakui_zhao
2009-05-11 15:21 ` Rafael J. Wysocki
2009-05-12 0:48 ` yakui_zhao
2009-05-12 2:01 ` Matthew Garrett
2009-05-12 2:26 ` yakui_zhao
2009-05-12 2:50 ` Matthew Garrett [this message]
2009-05-12 3:06 ` yakui_zhao
2009-05-12 4:11 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090512025017.GB24896@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=Witold.Szczeponik@gmx.net \
--cc=bjorn.helgaas@hp.com \
--cc=cedric@belbone.be \
--cc=hmh@hmh.eng.br \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.