From: Al Viro <viro@ZenIV.linux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] ->write_super lock_super pushdown
Date: Tue, 12 May 2009 05:12:19 +0100 [thread overview]
Message-ID: <20090512041219.GM8633@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20090511213503.GB19326@lst.de>
On Mon, May 11, 2009 at 11:35:03PM +0200, Christoph Hellwig wrote:
>
> Push down lock_super into ->write_super instances and remove it from the
> caller.
>
> Following filesystem don't need ->s_lock in ->write_super and are skipped:
>
> * bfs, nilfs2 - no other uses of s_lock and have internal locks in
> ->write_super
> * ext2 - uses BKL in ext2_write_super and has internal calls without s_lock
> * reiserfs - no other uses of s_lock as has reiserfs_write_lock (BKL) in
> ->write_super
Ehh... I'm not at all sure that reiserfs one is OK, but we are not exposing
any races that didn't exist before ;-/
next prev parent reply other threads:[~2009-05-12 4:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 21:35 [PATCH 2/2] ->write_super lock_super pushdown Christoph Hellwig
2009-05-12 4:12 ` Al Viro [this message]
2009-05-12 10:10 ` Boaz Harrosh
2009-05-12 13:25 ` Christoph Hellwig
2009-05-12 13:40 ` Al Viro
-- strict thread matches above, loose matches on Subject: below --
2009-05-06 20:16 Christoph Hellwig
2009-05-06 20:36 ` Christoph Hellwig
2009-05-06 22:38 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090512041219.GM8633@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.