All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: cmm@us.ibm.com, tytso@mit.edu, sandeen@redhat.com
Cc: linux-ext4@vger.kernel.org
Subject: [PATCH -V5] ext4: Use -1 as the fake block number for delayed new buffer_head
Date: Tue, 12 May 2009 20:47:54 +0530	[thread overview]
Message-ID: <20090512151754.GC23862@skywalker> (raw)
In-Reply-To: <1240980441-8105-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com>


ext4: Use a fake block number for delayed new buffer_head

From: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>

Use a very large unsigned number (~0xffff) as as the fake block number
for the delayed new buffer. The VFS should never try to write out this
number, but if it does, this will make it obvious.

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
 fs/ext4/inode.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 498cf8b..4b1478c 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -2297,6 +2297,10 @@ static int ext4_da_get_block_prep(struct inode *inode, sector_t iblock,
 				  struct buffer_head *bh_result, int create)
 {
 	int ret = 0;
+	sector_t invalid_block = ~((sector_t) 0xffff);
+
+	if (invalid_block < ext4_blocks_count(EXT4_SB(inode->i_sb)->s_es))
+		invalid_block = ~0;
 
 	BUG_ON(create == 0);
 	BUG_ON(bh_result->b_size != inode->i_sb->s_blocksize);
@@ -2318,7 +2322,7 @@ static int ext4_da_get_block_prep(struct inode *inode, sector_t iblock,
 			/* not enough space to reserve */
 			return ret;
 
-		map_bh(bh_result, inode->i_sb, 0);
+		map_bh(bh_result, inode->i_sb, invalid_block);
 		set_buffer_new(bh_result);
 		set_buffer_delay(bh_result);
 	} else if (ret > 0) {

  parent reply	other threads:[~2009-05-12 15:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-29  4:47 [PATCH -V4 1/2] Fix sub-block zeroing for buffered writes into unwritten extents Aneesh Kumar K.V
2009-04-29  4:47 ` [PATCH -V4 2/2] ext4: Use -1 as the fake block number for delayed new buffer_head Aneesh Kumar K.V
2009-04-29 13:59   ` Eric Sandeen
2009-04-29 15:35   ` Theodore Tso
2009-04-29 15:37     ` Eric Sandeen
2009-04-29 16:52       ` Theodore Tso
2009-04-29 17:01         ` Eric Sandeen
2009-05-04  8:54     ` Aneesh Kumar K.V
2009-05-04 15:06       ` Eric Sandeen
2009-05-12 15:17   ` Aneesh Kumar K.V [this message]
2009-04-29 13:59 ` [PATCH -V4 1/2] Fix sub-block zeroing for buffered writes into unwritten extents Eric Sandeen
2009-04-29 17:28   ` Mingming
2009-05-12  2:42 ` Theodore Tso
2009-05-12  3:37   ` Eric Sandeen
2009-05-12 15:16   ` [PATCH -V5] Fix sub-block zeroing for buffered writes intounwritten extents Aneesh Kumar K.V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090512151754.GC23862@skywalker \
    --to=aneesh.kumar@linux.vnet.ibm.com \
    --cc=cmm@us.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.