All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Roel Kluin <roel.kluin@gmail.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	krh@redhat.com, linux1394-devel@lists.sourceforge.net,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] firewire: remove driver_data direct access of struct device
Date: Tue, 12 May 2009 09:43:51 -0700	[thread overview]
Message-ID: <20090512164351.GI16247@kroah.com> (raw)
In-Reply-To: <4A08B9AD.3030208@s5r6.in-berlin.de>

On Tue, May 12, 2009 at 01:50:05AM +0200, Stefan Richter wrote:
> Roel Kluin wrote:
> > To avoid direct access to the driver_data pointer in struct device, the
> > functions dev_get_drvdata() and dev_set_drvdata() should be used.
> > 
> > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> 
> Greg has this already in his driver core tree.
> 
> BTW Greg, just in case, the patches
> "firewire: remove driver_data direct access of struct device" and
> "ieee1394: remove driver_data direct access of struct device"
> which you posted on April 30 are
> Acked-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Thanks, I've added your acks to the patches.

greg k-h

      reply	other threads:[~2009-05-12 17:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-11 20:18 [PATCH] firewire: remove driver_data direct access of struct device Roel Kluin
2009-05-11 23:50 ` Stefan Richter
2009-05-12 16:43   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090512164351.GI16247@kroah.com \
    --to=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=krh@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=roel.kluin@gmail.com \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.