From: Mike Snitzer <snitzer@redhat.com>
To: lvm-devel@redhat.com
Subject: Re: vgimportclone: script to import SAN snapshots and clones
Date: Wed, 13 May 2009 08:55:09 -0400 [thread overview]
Message-ID: <20090513125508.GB2267@redhat.com> (raw)
In-Reply-To: <20090513023333.GD10652@agk-dp.fab.redhat.com>
On Tue, May 12 2009 at 10:33pm -0400,
Alasdair G Kergon <agk@redhat.com> wrote:
> On Tue, May 12, 2009 at 06:47:25PM -0400, Mike Snitzer wrote:
> > Revised vgimportclone that should be ready for inclussion in the LVM2
> > tree.
I was certainly mistaken with that statement :)
I'll sort out all of your comments and repost.
> > + exec 2> ./${SCRIPTNAME}.log
>
> Errr ./ ??? What directory are we in and what file might we be clobbering?
> (Security blocker.) Better to retain output from earlier runs too and
> ensure there's a timestamp of the run somewhere (cf. lvmdump).
Yes, this DEBUG functionality is not safe at all; not sure how I missed
this.
Mike
prev parent reply other threads:[~2009-05-13 12:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 22:47 [PATCH] vgimportclone: script to import SAN snapshots and clones Mike Snitzer
2009-05-13 2:33 ` Alasdair G Kergon
2009-05-13 12:55 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090513125508.GB2267@redhat.com \
--to=snitzer@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.