From: Daniel Mack <daniel@caiaq.de>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
USB list <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] usb-serial: ftdi: don't dereference NULL pointer
Date: Wed, 13 May 2009 16:41:59 +0200 [thread overview]
Message-ID: <20090513144159.GI32424@buzzloop.caiaq.de> (raw)
In-Reply-To: <20090513143536.GA3443@kroah.com>
On Wed, May 13, 2009 at 07:35:36AM -0700, Greg KH wrote:
> On Wed, May 13, 2009 at 01:21:43PM +0200, Daniel Mack wrote:
> > The FTDI USB serial driver dereferences its priv structure in
> > ftdi_close() without checking for NULL pointer conditions, see the Oops
> > attached.
>
> Hm, I think this was already resolved with Alan's patch that went in
> right after 2.6.30-rc5 came out.
That was a similiar issue, yes. But it occured under different
circumstances, not under the condition I described.
> Can you check Linus's current tree to
> see if we still need this patch or not?
Is is needed, yes. I'm working on Linus' git as of this morning, so I'm
cutting edge mainline and can still perfectly reproduce the problem.
Not anymore with my patch, though.
Daniel
next prev parent reply other threads:[~2009-05-13 14:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-13 11:21 [PATCH] usb-serial: ftdi: don't dereference NULL pointer Daniel Mack
2009-05-13 14:35 ` Greg KH
2009-05-13 14:41 ` Daniel Mack [this message]
2009-05-13 14:48 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090513144159.GI32424@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.