All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Prendel <andre.prendel@gmx.de>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH v2 1/7] sensord: Remove commandline
Date: Wed, 13 May 2009 16:16:51 +0000	[thread overview]
Message-ID: <20090513161651.GA17670@ubuntu> (raw)
In-Reply-To: <20090511160022.GB17530@ubuntu>

On Tue, May 12, 2009 at 06:23:21PM +0200, Jean Delvare wrote:
> On Mon, 11 May 2009 18:00:23 +0200, Andre Prendel wrote:
> > Remove the hidden commandline interface of sensord.
> > 
> > Sensord can be invoked as an console application. Therefor a link
> > named sensors pointing to sensord is needed. That is very
> > intransparent and IMO useless. Printing sensor values to console is
> > done by the sensors tool.
> > 
> > Changes in v2:
> > 
> > Remove references to isDaemon.
> > Rename daemonShortOptions to shortOptions and daemonLongOptions to
> > longOptions.
> > Remove commandline flags doScan and doSet. They are needless without
> > the CLI.
> > Cleanup main().
> 
> Looks good to me.
> 
> > Jean, there is some more useless stuff after the removal of the CLI
> > (e.g. the DO_SET action in doChip). I would prefer first to get this
> > series applied and remove the remaining stuff in further patches. Is
> > this OK for you?
> 
> Yes, this is OK with me. Function setChips() can be killed too.

I've just applied the whole series.

Thanks,
Andre

> 
> -- 
> Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

      parent reply	other threads:[~2009-05-13 16:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-11 16:00 [lm-sensors] [PATCH v2 1/7] sensord: Remove commandline interface Andre Prendel
2009-05-12 16:23 ` [lm-sensors] [PATCH v2 1/7] sensord: Remove commandline Jean Delvare
2009-05-13 16:16 ` Andre Prendel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090513161651.GA17670@ubuntu \
    --to=andre.prendel@gmx.de \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.