diff for duplicates of <20090514162201.GA2361@cmpxchg.org> diff --git a/a/1.txt b/N1/1.txt index 19d3b8c..1584df2 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,23 +1,23 @@ On Thu, May 14, 2009 at 11:39:49PM +0900, Minchan Kim wrote: > On Thu, May 14, 2009 at 11:27 PM, KOSAKI Motohiro > <kosaki.motohiro@jp.fujitsu.com> wrote: -> >> mm/vmscan.c | 2 +- -> >> 1 files changed, 1 insertions(+), 1 deletions(-) +> >> A mm/vmscan.c | A A 2 +- +> >> A 1 files changed, 1 insertions(+), 1 deletions(-) > >> > >> diff --git a/mm/vmscan.c b/mm/vmscan.c > >> index 2f9d555..621708f 100644 > >> --- a/mm/vmscan.c > >> +++ b/mm/vmscan.c > >> @@ -1577,7 +1577,7 @@ static void shrink_zone(int priority, struct zone *zone, -> >> * Even if we did not try to evict anon pages at all, we want to -> >> * rebalance the anon lru active/inactive ratio. -> >> */ -> >> - if (inactive_anon_is_low(zone, sc)) -> >> + if (inactive_anon_is_low(zone, sc) && nr_swap_pages > 0) -> >> shrink_active_list(SWAP_CLUSTER_MAX, zone, sc, priority, 0); +> >> A A A A * Even if we did not try to evict anon pages at all, we want to +> >> A A A A * rebalance the anon lru active/inactive ratio. +> >> A A A A */ +> >> - A A A if (inactive_anon_is_low(zone, sc)) +> >> + A A A if (inactive_anon_is_low(zone, sc) && nr_swap_pages > 0) +> >> A A A A A A A A shrink_active_list(SWAP_CLUSTER_MAX, zone, sc, priority, 0); > > > > -> > if (nr_swap_pages > 0 && inactive_anon_is_low(zone, sc)) +> > A A A if (nr_swap_pages > 0 && inactive_anon_is_low(zone, sc)) > > > > is better? > > compiler can't swap evaluate order around &&. @@ -48,3 +48,9 @@ be emitted for the read. So KOSAKI-san's is right. Your version results in bigger object code. Hannes + +-- +To unsubscribe, send a message with 'unsubscribe linux-mm' in +the body to majordomo@kvack.org. For more info on Linux MM, +see: http://www.linux-mm.org/ . +Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N1/content_digest index 120532b..abc375b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -16,23 +16,23 @@ "On Thu, May 14, 2009 at 11:39:49PM +0900, Minchan Kim wrote:\n" "> On Thu, May 14, 2009 at 11:27 PM, KOSAKI Motohiro\n" "> <kosaki.motohiro@jp.fujitsu.com> wrote:\n" - "> >> \302\240mm/vmscan.c | \302\240 \302\2402 +-\n" - "> >> \302\2401 files changed, 1 insertions(+), 1 deletions(-)\n" + "> >> A mm/vmscan.c | A A 2 +-\n" + "> >> A 1 files changed, 1 insertions(+), 1 deletions(-)\n" "> >>\n" "> >> diff --git a/mm/vmscan.c b/mm/vmscan.c\n" "> >> index 2f9d555..621708f 100644\n" "> >> --- a/mm/vmscan.c\n" "> >> +++ b/mm/vmscan.c\n" "> >> @@ -1577,7 +1577,7 @@ static void shrink_zone(int priority, struct zone *zone,\n" - "> >> \302\240 \302\240 \302\240 \302\240 * Even if we did not try to evict anon pages at all, we want to\n" - "> >> \302\240 \302\240 \302\240 \302\240 * rebalance the anon lru active/inactive ratio.\n" - "> >> \302\240 \302\240 \302\240 \302\240 */\n" - "> >> - \302\240 \302\240 \302\240 if (inactive_anon_is_low(zone, sc))\n" - "> >> + \302\240 \302\240 \302\240 if (inactive_anon_is_low(zone, sc) && nr_swap_pages > 0)\n" - "> >> \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240shrink_active_list(SWAP_CLUSTER_MAX, zone, sc, priority, 0);\n" + "> >> A A A A * Even if we did not try to evict anon pages at all, we want to\n" + "> >> A A A A * rebalance the anon lru active/inactive ratio.\n" + "> >> A A A A */\n" + "> >> - A A A if (inactive_anon_is_low(zone, sc))\n" + "> >> + A A A if (inactive_anon_is_low(zone, sc) && nr_swap_pages > 0)\n" + "> >> A A A A A A A A shrink_active_list(SWAP_CLUSTER_MAX, zone, sc, priority, 0);\n" "> >\n" "> >\n" - "> > \302\240 \302\240 \302\240 if (nr_swap_pages > 0 && inactive_anon_is_low(zone, sc))\n" + "> > A A A if (nr_swap_pages > 0 && inactive_anon_is_low(zone, sc))\n" "> >\n" "> > is better?\n" "> > compiler can't swap evaluate order around &&.\n" @@ -62,6 +62,12 @@ "\n" "So KOSAKI-san's is right. Your version results in bigger object code.\n" "\n" - "\tHannes" + "\tHannes\n" + "\n" + "--\n" + "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" + "the body to majordomo@kvack.org. For more info on Linux MM,\n" + "see: http://www.linux-mm.org/ .\n" + "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" -b66585b00dde007c0d28be8cbc248e8bb4c36836f5edd8cb7c064a20083a6f91 +ad10d66945e9187b4b5aae8eb92518b849e2cea8d456e3a9ece41b4dfced317c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.