From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sheng Yang Subject: Re: [PATCH] kvm: discard masking checking when initial MSI-X entries Date: Fri, 15 May 2009 09:59:15 +0800 Message-ID: <200905150959.15615.sheng@linux.intel.com> References: <1241494915-14517-1-git-send-email-sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Cc: Avi Kivity To: kvm@vger.kernel.org Return-path: Received: from mga05.intel.com ([192.55.52.89]:53657 "EHLO fmsmga101.fm.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754609AbZEOB6W (ORCPT ); Thu, 14 May 2009 21:58:22 -0400 In-Reply-To: <1241494915-14517-1-git-send-email-sheng@linux.intel.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Tuesday 05 May 2009 11:41:55 Sheng Yang wrote: > This meant to be with commit: adcf3594f9580bdf9b5e71f271b6088b185e017e, > otherwise QEmu only counts the MSI-X entries, but won't fill it... > > Signed-off-by: Sheng Yang > --- > hw/device-assignment.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/hw/device-assignment.c b/hw/device-assignment.c > index 0a5f850..bee0bd8 100644 > --- a/hw/device-assignment.c > +++ b/hw/device-assignment.c > @@ -858,8 +858,6 @@ static int assigned_dev_update_msix_mmio(PCIDevice > *pci_dev) if (entries_nr >= msix_nr.entry_nr) > break; > memcpy(&msg_ctrl, va + i * 16 + 12, 4); > - if (msg_ctrl & 0x1) > - continue; > memcpy(&msg_data, va + i * 16 + 8, 4); > if (msg_data == 0) > continue; Avi? -- regards Yang, Sheng