From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH RFC 2/2] tmp401: Add support for TI's
Date: Fri, 15 May 2009 08:00:41 +0000 [thread overview]
Message-ID: <20090515100041.409b1486@hyperion.delvare> (raw)
In-Reply-To: <20090514092456.GB6644@ubuntu>
On Fri, 15 May 2009 09:47:49 +0200, Hans de Goede wrote:
> On 05/14/2009 11:24 AM, Andre Prendel wrote:
> > + if(data->kind = TMP411_DEVICE_ID) {
>
> This should be:
> + if(data->kind = tmp411) {
>
> !!
This should actually be:
if (data->kind = tmp411) {
Something scripts/checkpatch.pl would have warned Andre about.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2009-05-15 8:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 9:24 [lm-sensors] [PATCH RFC 2/2] tmp401: Add support for TI's TMP411 Andre Prendel
2009-05-15 7:47 ` [lm-sensors] [PATCH RFC 2/2] tmp401: Add support for TI's Hans de Goede
2009-05-15 8:00 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090515100041.409b1486@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.