From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: martin.mohring@opensuse.org, mika.westerberg@iki.fi,
Riku Voipio <riku.voipio@iki.fi>
Subject: Re: [Qemu-devel] [PATCH] Revived GUEST_BASE support for usermode emulation targets [v4]
Date: Fri, 15 May 2009 11:09:48 +0100 [thread overview]
Message-ID: <200905151109.48825.paul@codesourcery.com> (raw)
In-Reply-To: <200905151102.58522.paul@codesourcery.com>
> > It is indeed broken. Since tcg_out_addi maps on x86_64 to tgen_arithi64
> > which doesn't accept 64bit values. But as Martin said, the currrent use
> > for this patch is just to add very minimal offsets.
>
> I that case you should be using lea for small offsets. The proper sequence
> for large offsets is movq (allows 64-bit immedaise); add.
>
> The offset is a user configurable option, so IMHO you should be supporting
> large offsets.
I'll also note that mmap_min_addr need not be a small value. It may be set to
~4G to flush out 32-bit pointer truncation errors.
Paul
next prev parent reply other threads:[~2009-05-15 10:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-29 18:03 [Qemu-devel] [PATCH 01/10] export mmap_find_vma for shmat riku.voipio
2009-04-29 18:03 ` [Qemu-devel] [PATCH 02/10] Implement shm* syscalls and fix 64/32bit errors riku.voipio
2009-04-29 18:03 ` [Qemu-devel] [PATCH 03/10] linux-user: implemented ELF coredump support for ARM target [v2] riku.voipio
2009-04-29 18:03 ` [Qemu-devel] [PATCH 04/10] linux-user: added x86 and x86_64 support for ELF coredump riku.voipio
2009-04-29 18:03 ` [Qemu-devel] [PATCH 05/10] linux-user: strace now handles guest strings correctly riku.voipio
2009-04-29 18:03 ` [Qemu-devel] [PATCH 06/10] Revived GUEST_BASE support for usermode emulation targets [v2] riku.voipio
2009-04-29 19:50 ` malc
2009-05-05 13:27 ` [Qemu-devel] [PATCH] Revived GUEST_BASE support for usermode emulation targets [v3] Riku Voipio
2009-05-05 13:53 ` Paul Brook
2009-05-05 14:18 ` Riku Voipio
2009-05-05 14:34 ` Paul Brook
2009-05-05 18:02 ` malc
2009-05-05 20:46 ` [Qemu-devel] [PATCH] Revived GUEST_BASE support for usermode emulation targets [v4] Riku Voipio
2009-05-15 2:25 ` Paul Brook
2009-05-15 8:41 ` Martin Mohring
2009-05-15 9:50 ` Paul Brook
2009-05-15 9:57 ` Riku Voipio
2009-05-15 10:02 ` Paul Brook
2009-05-15 10:09 ` Paul Brook [this message]
2009-05-15 12:07 ` malc
2009-05-15 10:12 ` Martin Mohring
2009-05-15 14:13 ` Riku Voipio
2009-05-15 15:25 ` Martin Mohring
2009-04-30 7:07 ` [Qemu-devel] [PATCH 06/10] Revived GUEST_BASE support for usermode emulation targets [v2] Martin Mohring
2009-04-29 18:03 ` [Qemu-devel] [PATCH 07/10] linux-user: fix utimensat when used as futimens riku.voipio
2009-04-29 18:03 ` [Qemu-devel] [PATCH 08/10] Fix struct termios host - target translation riku.voipio
2009-04-29 18:03 ` [Qemu-devel] [PATCH 09/10] linux-user: fix utimensat with NULL timespec riku.voipio
2009-04-29 18:03 ` [Qemu-devel] [PATCH 10/10] Return EOPNOTSUPP instead of ENOSYS for *xattr* syscalls riku.voipio
2009-04-30 7:09 ` [Qemu-devel] [PATCH 01/10] export mmap_find_vma for shmat Martin Mohring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905151109.48825.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=martin.mohring@opensuse.org \
--cc=mika.westerberg@iki.fi \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.