From: Frans Pop <elendil@planet.nl>
To: Len Brown <lenb@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Janne Kulmala <janne.t.kulmala@tut.fi>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@elte.hu>,
johnstul@us.ibm.com
Subject: Re: [PATCH] ACPI: idle: fix init-time TSC check regression
Date: Fri, 15 May 2009 12:57:43 +0200 [thread overview]
Message-ID: <200905151257.45285.elendil@planet.nl> (raw)
In-Reply-To: <alpine.LFD.2.00.0905141750100.24833@localhost.localdomain>
On Thursday 14 May 2009, Len Brown wrote:
> From: Len Brown <len.brown@intel.com>
>
> A previous 2.6.30 patch, a71e4917dc0ebbcb5a0ecb7ca3486643c1c9a6e2,
> (ACPI: idle: mark_tsc_unstable() at init-time, not run-time)
> erroneously disabled the TSC on systems that did not actually
> have valid deep C-states.
>
> Move the check after the deep-C-states are validated,
> via new helper, tsc_check_state(), hich replaces tsc_halts_in_c().
>
> Signed-off-by: Len Brown <len.brown@intel.com>
> Acked-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
OK on both my desktop (which had the regression) and laptop.
Tested-by: Frans Pop <elendil@planet.nl>
(Tested together with the 2 patches you sent later.)
Cheers,
FJP
prev parent reply other threads:[~2009-05-15 10:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 4:14 regression in TSC unstable? Steven Rostedt
2009-05-08 5:21 ` Len Brown
2009-05-08 12:07 ` Ingo Molnar
2009-05-11 0:26 ` Regression in TSC unstable -- confirmed Frans Pop
2009-05-11 14:22 ` [PATCH] ACPI: do not mark TSC unstable for invalid C-states Thomas Gleixner
2009-05-11 15:00 ` Steven Rostedt
2009-05-11 15:03 ` Frans Pop
2009-05-11 16:43 ` Janne Kulmala
2009-05-14 19:46 ` Len Brown
2009-05-14 20:09 ` Len Brown
2009-05-14 20:19 ` Thomas Gleixner
2009-05-14 21:55 ` [PATCH] ACPI: idle: fix init-time TSC check regression Len Brown
2009-05-14 22:27 ` Thomas Gleixner
2009-05-15 3:36 ` Len Brown
2009-05-14 22:31 ` Frans Pop
2009-05-15 5:40 ` [PATCH] ACPI: Idle C-states disabled by max_cstate should not disable the TSC Len Brown
2009-05-15 6:18 ` [PATCH] ACPI: idle: rename lapic timer workaround routines Len Brown
2009-05-15 8:28 ` Thomas Gleixner
2009-05-15 8:27 ` [PATCH] ACPI: Idle C-states disabled by max_cstate should not disable the TSC Thomas Gleixner
2009-05-15 10:57 ` Frans Pop [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905151257.45285.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=janne.t.kulmala@tut.fi \
--cc=johnstul@us.ibm.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.