From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756734AbZEOQ6K (ORCPT ); Fri, 15 May 2009 12:58:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753001AbZEOQ54 (ORCPT ); Fri, 15 May 2009 12:57:56 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:39459 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751423AbZEOQ54 (ORCPT ); Fri, 15 May 2009 12:57:56 -0400 Date: Fri, 15 May 2009 12:57:56 -0400 From: Christoph Hellwig To: Steven Rostedt Cc: LKML , Christoph Hellwig , Ingo Molnar , Frederic Weisbecker , Mathieu Desnoyers , Andrew Morton Subject: Re: [RFC] tracing: adding flags to events Message-ID: <20090515165756.GA29760@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nice! I gave it a try in the xfs tracer and it seems to work fine. One little suggestion, can we specifies the flags as the full value instead of bit positions? That's how the are specified in the enums/#defines naming them (either in the 1<