From: Christoph Hellwig <hch@infradead.org>
To: Sujit Karataparambil <sjt.kar@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 2/7] xfs: split inode flushing from xfs_sync_inodes_ag
Date: Fri, 15 May 2009 13:22:47 -0400 [thread overview]
Message-ID: <20090515172246.GC14804@infradead.org> (raw)
In-Reply-To: <921ca19c0905142152u2a8012a9jba6f1d5b856df7ad@mail.gmail.com>
On Fri, May 15, 2009 at 10:22:31AM +0530, Sujit Karataparambil wrote:
> here also should there be an
> xfs_sync_inode_data(ip, flags);
> xfs_iflush(ip, XFS_IFLUSH_SYNC);
>
> in out_unlock.
No. We only want to perform the iflush if all the preconditions are met
in the !SYNC_WAIT case. And we certainly do not want to do a data
writeout from the metadata flush case - for one thing it does require
the iolock, but most importantly the point of this series is to separate
the two actions.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-05-15 17:22 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 17:12 [PATCH 0/7] inode sync refactoring Christoph Hellwig
2009-05-14 17:12 ` [PATCH 1/7] xfs: split inode data writeback from xfs_sync_inodes_ag Christoph Hellwig
2009-05-15 4:49 ` Sujit Karataparambil
2009-05-15 17:21 ` Christoph Hellwig
2009-05-18 6:58 ` Dave Chinner
2009-05-26 20:14 ` Eric Sandeen
2009-05-14 17:12 ` [PATCH 2/7] xfs: split inode flushing " Christoph Hellwig
2009-05-15 4:52 ` Sujit Karataparambil
2009-05-15 17:22 ` Christoph Hellwig [this message]
2009-05-26 20:45 ` Eric Sandeen
2009-05-27 10:58 ` Christoph Hellwig
2009-05-27 20:11 ` Eric Sandeen
2009-05-14 17:12 ` [PATCH 3/7] xfs: factor out inode validation for sync Christoph Hellwig
2009-05-27 20:38 ` Eric Sandeen
2009-05-14 17:12 ` [PATCH 4/7] xfs: remove unused parameter from xfs_reclaim_inodes Christoph Hellwig
2009-05-27 20:44 ` Eric Sandeen
2009-05-14 17:12 ` [PATCH 5/7] xfs: introduce a per-ag inode iterator Christoph Hellwig
2009-06-03 22:01 ` Eric Sandeen
2009-06-04 11:00 ` Christoph Hellwig
2009-06-03 22:18 ` Eric Sandeen
2009-06-04 17:17 ` Christoph Hellwig
2009-06-05 18:18 ` Eric Sandeen
2009-05-14 17:12 ` [PATCH 6/7] xfs: use generic inode iterator in xfs_qm_dqrele_all_inodes Christoph Hellwig
2009-06-03 23:29 ` Josef 'Jeff' Sipek
2009-06-05 19:15 ` Eric Sandeen
2009-06-05 19:17 ` Christoph Hellwig
2009-06-05 20:11 ` Eric Sandeen
2009-05-14 17:12 ` [PATCH 7/7] xfs: split xfs_sync_inodes Christoph Hellwig
2009-06-03 23:26 ` Josef 'Jeff' Sipek
2009-06-04 10:45 ` Christoph Hellwig
2009-06-05 20:32 ` Eric Sandeen
2009-05-28 12:19 ` [PATCH 8/7] xfs: remove SYNC_IOWAIT Christoph Hellwig
2009-06-03 23:30 ` Josef 'Jeff' Sipek
2009-06-04 10:46 ` Christoph Hellwig
2009-06-05 20:37 ` Eric Sandeen
2009-05-28 12:19 ` [PATCH 9/7] xfs: remove SYNC_BDFLUSH Christoph Hellwig
2009-05-29 13:19 ` Sujit Karataparambil
2009-05-29 20:10 ` Christoph Hellwig
2009-05-30 8:27 ` Sujit Karataparambil
2009-06-05 20:45 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090515172246.GC14804@infradead.org \
--to=hch@infradead.org \
--cc=sjt.kar@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.