From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfsprogs: add fallocate command to xfs_io
Date: Fri, 15 May 2009 13:27:11 -0400 [thread overview]
Message-ID: <20090515172711.GA23630@infradead.org> (raw)
In-Reply-To: <20090515171324.GA14804@infradead.org>
On Fri, May 15, 2009 at 01:13:24PM -0400, Christoph Hellwig wrote:
> On Sun, May 10, 2009 at 07:30:13PM -0500, Eric Sandeen wrote:
> > Based on Dave's earlier patch, but now we have an fallocate
> > glibc call... this also adds autoconf magic and a manpage
> > update.
> >
> > (hopefully not too #ifdef-heavy....)
>
> Looks good to me and seems to work.
Actually that was spoken too fast. On my Debian -testing system it
detects fallocate as available because <linux/falloc.h> exists, but the
glibc doesn't actually support a falloc(3) yet. So either the detection
needs to be improved or we need to use the raw syscall.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-05-15 17:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 0:30 [PATCH] xfsprogs: add fallocate command to xfs_io Eric Sandeen
2009-05-15 17:13 ` Christoph Hellwig
2009-05-15 17:27 ` Christoph Hellwig [this message]
2009-05-15 18:50 ` Eric Sandeen
2009-05-15 22:11 ` Eric Sandeen
2009-05-16 20:40 ` Christoph Hellwig
2009-05-16 22:08 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090515172711.GA23630@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.