All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4] Separate mtdparts command from jffs2
Date: Sat, 16 May 2009 06:08:34 +0200	[thread overview]
Message-ID: <200905160608.34956.sr@denx.de> (raw)
In-Reply-To: <20090515153217.77AFF832E416@gemini.denx.de>

Hi Wolfgang,

On Friday 15 May 2009 17:32:17 Wolfgang Denk wrote:
> > Currently the mtdparts commands are included in the jffs2 command
> > support. This doesn't make sense anymore since other commands (e.g. UBI)
> > use this infrastructure as well now. This patch separates the mtdparts
> > commands from the jffs2 commands making it possible to only select
> > mtdparts when no JFFS2 support is needed.
> >
> > Signed-off-by: Stefan Roese <sr@denx.de>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>
> As it turns out, that split was incomplete or incorrect.
>
> It seems that since commit 68d7d65100 we have two different,
> incompatible implementations of mtdparts_init() - one in
> common/cmd_jffs2.c and another one in common/cmd_mtdparts.c
>
> When NAND and JFFS2 and MTDPARTS are enabled at the same time, the
> mtdparts_init() from common/cmd_mtdparts.c is called, which obviously
> does not pereform the required intializations for JFFS2: all JFFS2
> related commands just return without any error messages but also
> without any useful output either.

Sorry about this.

> Please provide a fix!

OK, I'll try to come up with a patch quickly.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

      reply	other threads:[~2009-05-16  4:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-19 12:30 [U-Boot] [PATCH v4] Separate mtdparts command from jffs2 Stefan Roese
2009-03-20 21:04 ` Wolfgang Denk
2009-03-23 11:06 ` Ladislav Michl
2009-04-04 20:42   ` Wolfgang Denk
2009-04-21  0:26 ` Ladislav Michl
2009-04-21  4:03   ` Stefan Roese
2009-04-27 23:06   ` Wolfgang Denk
2009-05-15 15:32 ` Wolfgang Denk
2009-05-16  4:08   ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905160608.34956.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.