From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>
Cc: linux-scsi@vger.kernel.org
Subject: [PATCH] scsi_error: fix scsi_eh_lock_door() documentation
Date: Sat, 16 May 2009 21:26:21 +0200 [thread overview]
Message-ID: <200905162126.22659.bzolnier@gmail.com> (raw)
Nowadays eh_lock_door_done() uses blk_get_request() instead of
scsi_allocate_request().
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
on top of linux-next
drivers/scsi/scsi_error.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Index: b/drivers/scsi/scsi_error.c
===================================================================
--- a/drivers/scsi/scsi_error.c
+++ b/drivers/scsi/scsi_error.c
@@ -1451,7 +1451,7 @@ static void eh_lock_door_done(struct req
* @sdev: SCSI device to prevent medium removal
*
* Locking:
- * We must be called from process context; scsi_allocate_request()
+ * We must be called from process context; blk_get_request()
* may sleep.
*
* Notes:
@@ -1459,11 +1459,11 @@ static void eh_lock_door_done(struct req
* head of the devices request queue, and continue.
*
* Bugs:
- * scsi_allocate_request() may sleep waiting for existing requests to
+ * blk_get_request() may sleep waiting for existing requests to
* be processed. However, since we haven't kicked off any request
* processing for this host, this may deadlock.
*
- * If scsi_allocate_request() fails for what ever reason, we
+ * If blk_get_request() fails for what ever reason, we
* completely forget to lock the door.
*/
static void scsi_eh_lock_door(struct scsi_device *sdev)
next reply other threads:[~2009-05-16 19:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-16 19:26 Bartlomiej Zolnierkiewicz [this message]
2009-05-17 14:30 ` [PATCH] scsi_error: fix scsi_eh_lock_door() documentation James Bottomley
2009-05-17 15:18 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905162126.22659.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.